You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mbrobbel (via GitHub)" <gi...@apache.org> on 2025/08/27 11:24:15 UTC
[PR] feat(rust/arrow): re-export `arrow-*` crates in `adbc_core` [arrow-adbc]
mbrobbel opened a new pull request, #3354:
URL: https://github.com/apache/arrow-adbc/pull/3354
`adbc_core` defines public items that use types from both the `arrow-array` and `arrow-schema` crates. This PR adds a re-export of those crates (in an `arrow` mod) to the `adbc_core` crate. This means other crates no longer need to directly depend on the `arrow` crates for types from those crates used in `adbc_core`. Overall this should make it easier to use this crate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(rust): re-export `arrow-*` crates in `adbc_core` [arrow-adbc]
Posted by "mbrobbel (via GitHub)" <gi...@apache.org>.
mbrobbel commented on code in PR #3354:
URL: https://github.com/apache/arrow-adbc/pull/3354#discussion_r2308029149
##########
rust/driver/datafusion/Cargo.toml:
##########
@@ -32,17 +32,11 @@ categories.workspace = true
[dependencies]
adbc_core.workspace = true
-arrow-array = "55.2.0"
-arrow-buffer = "55.2.0"
-arrow-schema = "55.2.0"
Review Comment:
Normal dependents of `adbc_core` can still select any of the supported arrow versions, but the adbc workspace uses the arrow version of datafusion. Maybe we should re-consider moving this driver out the workspace or to the datafusion repository (as discussed before)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(rust): re-export `arrow-*` crates in `adbc_core` [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #3354:
URL: https://github.com/apache/arrow-adbc/pull/3354#issuecomment-3231674354
CC @eitsupi @felipecrv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(rust): re-export `arrow-*` crates in `adbc_core` [arrow-adbc]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on code in PR #3354:
URL: https://github.com/apache/arrow-adbc/pull/3354#discussion_r2307767937
##########
rust/driver/datafusion/Cargo.toml:
##########
@@ -32,17 +32,11 @@ categories.workspace = true
[dependencies]
adbc_core.workspace = true
-arrow-array = "55.2.0"
-arrow-buffer = "55.2.0"
-arrow-schema = "55.2.0"
Review Comment:
Are we now back to requiring that the Datafusion driver and the ADBC code libraries use the same Arrow version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(rust): re-export `arrow-*` crates in `adbc_core` [arrow-adbc]
Posted by "eitsupi (via GitHub)" <gi...@apache.org>.
eitsupi commented on PR #3354:
URL: https://github.com/apache/arrow-adbc/pull/3354#issuecomment-3233854231
I think this change makes sense, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(rust): re-export `arrow-*` crates in `adbc_core` [arrow-adbc]
Posted by "mbrobbel (via GitHub)" <gi...@apache.org>.
mbrobbel commented on PR #3354:
URL: https://github.com/apache/arrow-adbc/pull/3354#issuecomment-3234306571
> An application using ADBC is very likely using Arrow already (and it needs other arrow crates) and should be explicitly choosing the Arrow version they are using instead of implicitly inhering whatever ADBC Core used.
>
True; there might be cases where the types used in `adbc_core` are enough, but it's more likely that applications need more arrow types.
> ADBC drivers are neutral regarding Arrow version and the manager should be as neutral as it can be.
Should be easy, but it also depends on the driver need more arrow types or not.
I'll think about it a little bit more - my hope was that this would make it a little bit easier to deal with datafusion and arrow updates, but it might not be ideal for downstream users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org