You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xuchuanyin <gi...@git.apache.org> on 2018/04/28 06:13:44 UTC

[GitHub] carbondata pull request #2242: [HOTFIX][Search] Carbon should throw exceptio...

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2242#discussion_r184841885
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecuterImpl.java ---
    @@ -193,7 +193,9 @@ private void initMeasureChunkIndexes() {
       public BitSetGroup applyFilter(RawBlockletColumnChunks rawBlockletColumnChunks,
           boolean useBitsetPipeLine) throws FilterUnsupportedException, IOException {
         if (exp instanceof MatchExpression) {
    -      return rawBlockletColumnChunks.getBitSetGroup();
    +      // if there are datamap created on this table, it should not come to here
    +      throw new FilterUnsupportedException(
    +          exp.getFilterExpressionType().name() + " is not supported on this table");
    --- End diff --
    
    Won't it be better to add tableName information to the error message, such as
    ```
    ... is not supported on $dbName.$tableName
    ```


---