You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "tomaswolf (via GitHub)" <gi...@apache.org> on 2024/11/07 22:08:00 UTC
[PR] GH-628: Fix reading directories with trailing blanks in the name [mina-sshd]
tomaswolf opened a new pull request, #630:
URL: https://github.com/apache/mina-sshd/pull/630
`ValidateUtils.checkNotNullAndNotEmpty(String, ...)` as a side-effect returns the trimmed string!
Add new methods `ValidateUtils.hasContent(String, ...)` that don't do so, and use that instead.
Fixes #628.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] GH-628: Fix reading directories with trailing blanks in the name [mina-sshd]
Posted by "dadoonet (via GitHub)" <gi...@apache.org>.
dadoonet commented on PR #630:
URL: https://github.com/apache/mina-sshd/pull/630#issuecomment-2465685248
Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] GH-628: Fix reading directories with trailing blanks in the name [mina-sshd]
Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf commented on PR #630:
URL: https://github.com/apache/mina-sshd/pull/630#issuecomment-2541460809
Short answer: end of January or first half of February 2025, but that's my personal goal only.
Long answer:
We don't have a fixed release plan. There's no organization large enough backing this project that would provide reliable manpower for regular releases. It's all individual volunteer effort; releases being done by @gnodet, and before being published releases have to go through a review and voting phase by the MINA PMC. Even if Guillaume might have time to cut a 2.14.2 release now, I don't know if the other PMC members would have time to review it. I know that I am unlikely to have that time this month.
With my Eclipse developer hat on, I'd like to include a new release of Apache MINA sshd in JGit and in Eclipse for its next release (March 12, 2025). Which means I aim for a 2.15.0 release around end of January 2025. 2.15.0 should include PR #639 and it should be prepared to work with or without `SecurityManager`, which AFAIK will finally disappear in Java 24 (also March 2025).
This fix here _is_ already available in the snaphot release from the [Apache snapshots](https://repository.apache.org/content/repositories/snapshots/) repository. As a stop-gap measure you might just use that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] GH-628: Fix reading directories with trailing blanks in the name [mina-sshd]
Posted by "dadoonet (via GitHub)" <gi...@apache.org>.
dadoonet commented on PR #630:
URL: https://github.com/apache/mina-sshd/pull/630#issuecomment-2541505926
Thanks! It's helpful.
> it should be prepared to work with or without `SecurityManager`
Yeah. I'm sad this has been removed from the JVM. It was so useful for Elastic and that's how we did not suffer from the Log4Shell disaster...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] GH-628: Fix reading directories with trailing blanks in the name [mina-sshd]
Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf merged PR #630:
URL: https://github.com/apache/mina-sshd/pull/630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] GH-628: Fix reading directories with trailing blanks in the name [mina-sshd]
Posted by "dadoonet (via GitHub)" <gi...@apache.org>.
dadoonet commented on PR #630:
URL: https://github.com/apache/mina-sshd/pull/630#issuecomment-2541382909
@tomaswolf Any idea of when you will most likely be releasing a new version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] GH-628: Fix reading directories with trailing blanks in the name [mina-sshd]
Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf commented on PR #630:
URL: https://github.com/apache/mina-sshd/pull/630#issuecomment-2465799647
Thanks you; you're welcome. Caused by poor coding in ages-old code; one really wouldn't expect a method named "checkNotNullAndNotEmpty" to have such a side effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org