You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "liyang (JIRA)" <ji...@apache.org> on 2018/01/01 00:20:00 UTC

[jira] [Commented] (KYLIN-2990) Add warning window of exist model names for other project selected

    [ https://issues.apache.org/jira/browse/KYLIN-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307337#comment-16307337 ] 

liyang commented on KYLIN-2990:
-------------------------------

Note I reverted the check-dup logic in ModelService. Many direct REST API calls still relies on it. Please check if this impact the wanted behavior under this JIRA.

> Add warning window of exist model names for other project selected
> ------------------------------------------------------------------
>
>                 Key: KYLIN-2990
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2990
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Web 
>            Reporter: peng.jianhua
>            Assignee: peng.jianhua
>             Fix For: v2.3.0
>
>         Attachments: 0001-KYLIN-2990-Add-warning-window-of-exist-model-names-f.patch, 01.PNG, 02.PNG, 03.PNG
>
>
> I noticed that when we intend to build a new model and named it as  'kylin_sales_model' in project 'learn_kylin'.
> we will get the prompt like 01.png.
> Cause we have already own the same name model.
> But if we build the same name model 'kylin_sales_model' in another project such as project_1,
> we can't get the warning prompt until the last step. please refer to 02.png.
> I found that we just check the model in the selected project not all project.
> It's improper that we recognize the minor mistake until the final step,and we should change the name in the first step and click 'next' buttun four times.
> We should offer the same prompt for other projects.
> So I modify the code in 'modelSchema.js',we can get the prompt in the first step,please refer to 03.png.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)