You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/09 03:09:23 UTC

[GitHub] [flink] zhengcanbin commented on issue #11346: [FLINK-16493][k8s] Use enum type instead of string type for KubernetesConfigOptions.REST_SERVICE_EXPOSED_TYPE

zhengcanbin commented on issue #11346: [FLINK-16493][k8s] Use enum type instead of string type for KubernetesConfigOptions.REST_SERVICE_EXPOSED_TYPE
URL: https://github.com/apache/flink/pull/11346#issuecomment-596311156
 
 
   > Thanks for your contribution @zhengcanbin !
   > 
   > One thing to double check: from user perspective, configuration settings work without any modification, right?
   > 
   > @knaufk is there any impact switch from string option to enum option?
   
   Well, it depends!
   
   1. It does not affect the flink-conf.yaml setting way.
   2. It does not affect the -D setting way for the kubernetes-session script.
   3. If people get/set it directly via the Configuration object in the code, this switch requires them to modify code. However, I think people rarely set/get this option in such a way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services