You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2025/10/01 15:08:29 UTC
[PR] chore: bump version and fix up metadata [opendal-reqsign]
tisonkun opened a new pull request, #642:
URL: https://github.com/apache/opendal-reqsign/pull/642
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: bump version and fix up metadata [opendal-reqsign]
Posted by "BurntSushi (via GitHub)" <gi...@apache.org>.
BurntSushi commented on code in PR #642:
URL: https://github.com/apache/opendal-reqsign/pull/642#discussion_r2395363187
##########
core/Cargo.toml:
##########
@@ -17,31 +17,30 @@
[package]
name = "reqsign-core"
-version = "1.0.0"
+version = "1.1.0"
Review Comment:
Didn't y'all switch over to Jiff entire, including [changing the definition of a public type alias](https://docs.rs/reqsign-core/latest/reqsign_core/time/type.DateTime.html)? And consequently, the inputs and outputs of the various functions in `reqsign_core::time`.
That isn't minor breakage. You absolutely have to do a 2.0 release.
##########
core/Cargo.toml:
##########
@@ -17,31 +17,30 @@
[package]
name = "reqsign-core"
-version = "1.0.0"
+version = "1.1.0"
Review Comment:
Didn't y'all switch over to Jiff entirely, including [changing the definition of a public type alias](https://docs.rs/reqsign-core/latest/reqsign_core/time/type.DateTime.html)? And consequently, the inputs and outputs of the various functions in `reqsign_core::time`.
That isn't minor breakage. You absolutely have to do a 2.0 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: bump version and fix up metadata [opendal-reqsign]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #642:
URL: https://github.com/apache/opendal-reqsign/pull/642#discussion_r2394979334
##########
reqsign/Cargo.toml:
##########
@@ -19,20 +19,22 @@
name = "reqsign"
version = "0.17.0"
Review Comment:
At 109b68e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: bump version and fix up metadata [opendal-reqsign]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #642:
URL: https://github.com/apache/opendal-reqsign/pull/642#discussion_r2394975294
##########
reqsign/Cargo.toml:
##########
@@ -19,20 +19,22 @@
name = "reqsign"
version = "0.17.0"
Review Comment:
I think this can be `0.17.1` since no breaking at the surface of `reqsign`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: bump version and fix up metadata [opendal-reqsign]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #642:
URL: https://github.com/apache/opendal-reqsign/pull/642#discussion_r2396676862
##########
core/Cargo.toml:
##########
@@ -17,31 +17,30 @@
[package]
name = "reqsign-core"
-version = "1.0.0"
+version = "1.1.0"
Review Comment:
Let me try to encapsulate time interfaces like https://github.com/fast/cronexpr?tab=readme-ov-file#dependencies >~<
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: bump version and fix up metadata [opendal-reqsign]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #642:
URL: https://github.com/apache/opendal-reqsign/pull/642#discussion_r2394961708
##########
reqsign/Cargo.toml:
##########
@@ -19,20 +19,22 @@
name = "reqsign"
version = "0.17.0"
Review Comment:
The next version would be 0.18.0? @xuan
##########
reqsign/Cargo.toml:
##########
@@ -19,20 +19,22 @@
name = "reqsign"
version = "0.17.0"
Review Comment:
The next version would be 0.18.0? @Xuanwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: bump version and fix up metadata [opendal-reqsign]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #642:
URL: https://github.com/apache/opendal-reqsign/pull/642#discussion_r2394960478
##########
core/Cargo.toml:
##########
@@ -17,31 +17,30 @@
[package]
name = "reqsign-core"
-version = "1.0.0"
+version = "1.1.0"
Review Comment:
#634 is a breaking change. But @Xuanwo and I would expect a minor version change anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: bump version and fix up metadata [opendal-reqsign]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #642:
URL: https://github.com/apache/opendal-reqsign/pull/642#discussion_r2394976040
##########
core/Cargo.toml:
##########
@@ -17,31 +17,30 @@
[package]
name = "reqsign-core"
-version = "1.0.0"
+version = "1.1.0"
Review Comment:
Yep, I think the breakage is very minor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: bump version and fix up metadata [opendal-reqsign]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #642:
URL: https://github.com/apache/opendal-reqsign/pull/642#discussion_r2394968912
##########
core/Cargo.toml:
##########
@@ -17,31 +17,30 @@
[package]
name = "reqsign-core"
-version = "1.0.0"
+version = "1.1.0"
Review Comment:
cc @BurntSushi
IIRC, you are experienced with version strategy. Would you suggest a 1.1.0 or 2.0.0? Given that most users use `reqsign` and we may yank 1.0.0 for "internal" core crates and service crates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: bump version and fix up metadata [opendal-reqsign]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #642:
URL: https://github.com/apache/opendal-reqsign/pull/642#discussion_r2398746671
##########
core/Cargo.toml:
##########
@@ -17,31 +17,30 @@
[package]
name = "reqsign-core"
-version = "1.0.0"
+version = "1.1.0"
Review Comment:
@BurntSushi Staged at https://github.com/apache/opendal-reqsign/pull/643. I'm considering how to expose `jiff`'s interfaces, especially since jiff is about to a 1.0 release that is also semantically a breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: bump version and fix up metadata [opendal-reqsign]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #642:
URL: https://github.com/apache/opendal-reqsign/pull/642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: bump version and fix up metadata [opendal-reqsign]
Posted by "BurntSushi (via GitHub)" <gi...@apache.org>.
BurntSushi commented on code in PR #642:
URL: https://github.com/apache/opendal-reqsign/pull/642#discussion_r2398773519
##########
core/Cargo.toml:
##########
@@ -17,31 +17,30 @@
[package]
name = "reqsign-core"
-version = "1.0.0"
+version = "1.1.0"
Review Comment:
Yeah, doing a semver incompatible upgrade of a public dependency would in turn require a semver incompatible update for you as well.
This is why it's best to encapsulate public dependencies if possible. It's also why once I release jiff 1.0, I plan to stick with it indefinitely so that folks _can_ use it as a public dependency without this kind of churn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org