You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by iv...@apache.org on 2007/08/17 21:38:46 UTC

svn commit: r567118 - /wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/PageParameters.java

Author: ivaynberg
Date: Fri Aug 17 12:38:45 2007
New Revision: 567118

URL: http://svn.apache.org/viewvc?view=rev&rev=567118
Log:
this check breaks a lot of stuff in our apps which prob means it will break other apps as well. for example we do pageparameters.put("id",long) all over the place.

Modified:
    wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/PageParameters.java

Modified: wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/PageParameters.java
URL: http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/PageParameters.java?view=diff&rev=567118&r1=567117&r2=567118
==============================================================================
--- wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/PageParameters.java (original)
+++ wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/PageParameters.java Fri Aug 17 12:38:45 2007
@@ -142,22 +142,18 @@
 
 	public Object put(Object key, Object value)
 	{
-		if (!(key instanceof String))
-		{
-			throw new IllegalArgumentException(
-					"PageParameter keys must be of type String, but you supplied a " +
-							key.getClass().getName());
-		}
-		if (value instanceof String || value instanceof String[])
-		{
-			return super.put(key, value);
-		}
-		else
-		{
-			throw new IllegalArgumentException("You tried to add an object of type " +
-					value.getClass().getName() + " to your PageParameters for key " + key +
-					", but you are only allowed to use String or String[].");
-		}
+		return super.put(key, value);
+/*
+ * BRING BACK IN 1.4
+ * 
+ * if (!(key instanceof String)) { throw new IllegalArgumentException(
+ * "PageParameter keys must be of type String, but you supplied a " +
+ * key.getClass().getName()); } if (value instanceof String || value instanceof
+ * String[]) { return super.put(key, value); } else { throw new
+ * IllegalArgumentException("You tried to add an object of type " +
+ * value.getClass().getName() + " to your PageParameters for key " + key + ",
+ * but you are only allowed to use String or String[]."); }
+ */
 	}
 
 	/**