You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/03/30 12:29:52 UTC

[GitHub] [echarts] jiawulin001 commented on a change in pull request #16772: fix: Dump areaStyle polygon when notMerge is true

jiawulin001 commented on a change in pull request #16772:
URL: https://github.com/apache/echarts/pull/16772#discussion_r838483895



##########
File path: src/chart/line/LineView.ts
##########
@@ -730,6 +730,10 @@ class LineView extends ChartView {
                 polygon = this._newPolygon(
                     points, stackedOnPoints
                 );
+            }// If areaStyle is removed
+            else if(polygon){

Review comment:
       Hi, @plainheart thank you for scanning code for me. I've updated the code of two open PRs and do I need to submit another PR to update the code in the first PR? Just out of curiosity, what lint tool are you using? I am using sonarlint and it doesn't seem to bother reminding me of any of this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org