You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Jack Repenning <jr...@collab.net> on 2009/03/13 00:22:56 UTC
[PATCH] Fix typo in --help output of configure, for new syntax of
--with-berkeley-db arg
[[[
Fix typo in --help output of configure, for new syntax of --with-
berkeley-db arg.
* configure
(help text): Show proper syntax for omitting the optional arg.
]]]
--- configure 2009-02-27 12:02:27.000000000 -0800
+++ configure-new 2009-03-12 17:15:50.000000000 -0700
@@ -1717,7 +1717,7 @@
--with-tags[=TAGS] include additional configurations
[automatic]
--with-trang=PATH Specify the command to run the trang schema
converter
- --with-berkeley-db=[HEADER:INCLUDES:LIB_SEARCH_DIRS:LIBS]
+ --with-berkeley-db[=HEADER:INCLUDES:LIB_SEARCH_DIRS:LIBS]
The Subversion Berkeley DB based
filesystem library
requires Berkeley DB $db_version or newer.
If you
specify `--without-berkeley-db', that
library will
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1314938
Re: [PATCH] Fix typo in --help output of configure, for new syntax
of --with-berkeley-db arg
Posted by Jack Repenning <jr...@collab.net>.
Maybe better to attach the patch, instead of inline?
[[[
Fix typo in --help output of configure, for new syntax of --with-
berkeley-db arg.
* configure
(help text): Show proper syntax for omitting the optional arg.
]]]
-==-
Jack Repenning
Chief Technology Officer
CollabNet, Inc.
8000 Marina Boulevard, Suite 600
Brisbane, California 94005
office: +1 650.228.2562
mobile: +1 408.835.8090
raindance: +1 877.326.2337, x844.7461
aim: jackrepenning
skype: jackrepenning
twitter: http://twitter.com/jrep
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1315102
Re: Re: [PATCH] Fix typo in --help output of configure, for new
syntax of --with-berkeley-db arg
Posted by Daniel Rall <dl...@finemaltcoding.com>.
Patch still looks good, +1 for commit to mainline.
http://subversion.tigris.org/hacking.html#release-stabilization
describes the backport and release stabilization process. You're free
to nominate this change for backport, and cast a non-binding +1 in
favor of it. I'm fine backporting this change, so you can add my +1
too (though we could just as easily skip it).
On Thu, Mar 12, 2009 at 7:36 PM, Jack Repenning <jr...@collab.net> wrote:
> I am a partial committer, and I believe dlr's +1 authorizes me to make the commit. But I'm not doing that just yet, because I'm unclear on proper procedure at this point in a release: the change could and should go into both the 1.6.x branch and trunk, for instance, but I'm not certain whether dlr's approval applies to both. Then there are matters like, should I be careful about mergeinfo properties.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1316068
Re: [PATCH] Fix typo in --help output of configure, for new syntax
of --with-berkeley-db arg
Posted by Gavin Baumanis <ga...@thespidernet.com>.
Hi Jack,
On 22/04/2009, at 3:46 AM, Jack Repenning wrote:
>
> On Apr 20, 2009, at 11:41 PM, Gavin 'Beau' Baumanis wrote:
>
>> Hi Jack- et al,
>>
>> Just doing some PM cleanup and thought I would check if this has
>> been committed yet?
>> There was a period where I was not subscribed to the commit (svn)
>> mailing list and may have missed it going in.
>
> Yup, that's r36532 (into trunk, didn't seem worth back-porting).
>
> Did I neglect to do something or other when I did that?
Not specifically, no.
It does help me out, if the original thread is annotated with a
"committed in rxxxx".
Which would be a nice convention to agreement on - if possible... But
I wouldn't say it was a necessity.
Now that I am subscribed to the svn (commit) mailing list - I just do
a search for the file that is patched in those commit messages, review
the change to see if it the same as the [patch] contribution and go
from there.
But for a while - I was unsubscribed to that list and so have missed
a few weeks of the commit messages since I took over the PM role.
But thanks for the reply - I'll remove it from my "to watch" list.
Gavin.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1850884
Re: [PATCH] Fix typo in --help output of configure, for new syntax
of --with-berkeley-db arg
Posted by Jack Repenning <jr...@collab.net>.
On Apr 20, 2009, at 11:41 PM, Gavin 'Beau' Baumanis wrote:
> Hi Jack- et al,
>
> Just doing some PM cleanup and thought I would check if this has
> been committed yet?
> There was a period where I was not subscribed to the commit (svn)
> mailing list and may have missed it going in.
Yup, that's r36532 (into trunk, didn't seem worth back-porting).
Did I neglect to do something or other when I did that?
-==-
Jack Repenning
Chief Technology Officer
CollabNet, Inc.
8000 Marina Boulevard, Suite 600
Brisbane, California 94005
office: +1 650.228.2562
mobile: +1 408.835.8090
raindance: +1 877.326.2337, x844.7461
aim: jackrepenning
skype: jackrepenning
twitter: http://twitter.com/jrep
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1846602
Re: [PATCH] Fix typo in --help output of configure, for new syntax
of --with-berkeley-db arg
Posted by Gavin Baumanis <ga...@thespidernet.com>.
Hi Jack- et al,
Just doing some PM cleanup and thought I would check if this has been
committed yet?
There was a period where I was not subscribed to the commit (svn)
mailing list and may have missed it going in.
Gavin.
On 13/03/2009, at 1:36 PM, Jack Repenning wrote:
> I am a partial committer, and I believe dlr's +1 authorizes me to
> make the commit. But I'm not doing that just yet, because I'm
> unclear on proper procedure at this point in a release: the change
> could and should go into both the 1.6.x branch and trunk, for
> instance, but I'm not certain whether dlr's approval applies to
> both. Then there are matters like, should I be careful about
> mergeinfo properties.
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1315342
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1838336
RE: Re: [PATCH] Fix typo in --help output of configure, for new
syntax of --with-berkeley-db arg
Posted by Jack Repenning <jr...@collab.net>.
I am a partial committer, and I believe dlr's +1 authorizes me to make the commit. But I'm not doing that just yet, because I'm unclear on proper procedure at this point in a release: the change could and should go into both the 1.6.x branch and trunk, for instance, but I'm not certain whether dlr's approval applies to both. Then there are matters like, should I be careful about mergeinfo properties.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1315342
Re: [PATCH] Fix typo in --help output of configure, for new syntax
of --with-berkeley-db arg
Posted by Jack Repenning <jr...@collab.net>.
On Mar 12, 2009, at 6:29 PM, Daniel Rall wrote:
> +1 for commit.
Thanks. But, my bad: I guess this doesn't actually go into
"configure", which is after all a generated file, but rather into
build/ac-macros/berkeley-db.m4:
[[[
Fix typo in --help output of configure,
for new syntax of --with-berkeley-db arg.
* configure
(help text): Show proper syntax for omitting the optional arg.
]]]
-==-
Jack Repenning
Chief Technology Officer
CollabNet, Inc.
8000 Marina Boulevard, Suite 600
Brisbane, California 94005
office: +1 650.228.2562
mobile: +1 408.835.8090
raindance: +1 877.326.2337, x844.7461
aim: jackrepenning
skype: jackrepenning
twitter: http://twitter.com/jrep
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1315306
Re: [PATCH] Fix typo in --help output of configure, for new syntax
of --with-berkeley-db arg
Posted by Daniel Rall <dl...@finemaltcoding.com>.
+1 for commit.
On Thu, Mar 12, 2009 at 5:22 PM, Jack Repenning <jr...@collab.net> wrote:
> [[[
> Fix typo in --help output of configure, for new syntax of --with-
> berkeley-db arg.
>
> * configure
> (help text): Show proper syntax for omitting the optional arg.
> ]]]
>
>
> --- configure 2009-02-27 12:02:27.000000000 -0800
> +++ configure-new 2009-03-12 17:15:50.000000000 -0700
> @@ -1717,7 +1717,7 @@
> --with-tags[=TAGS] include additional configurations
> [automatic]
> --with-trang=PATH Specify the command to run the trang schema
> converter
> - --with-berkeley-db=[HEADER:INCLUDES:LIB_SEARCH_DIRS:LIBS]
> + --with-berkeley-db[=HEADER:INCLUDES:LIB_SEARCH_DIRS:LIBS]
> The Subversion Berkeley DB based
> filesystem library
> requires Berkeley DB $db_version or newer.
> If you
> specify `--without-berkeley-db', that
> library will
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1314938
>
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1315163