You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/05/21 02:18:05 UTC
Review Request 21740: Use rsync instead of git to copy code into vagrant,
simplify end-to-end tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21740/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
Bugs: AURORA-452
https://issues.apache.org/jira/browse/AURORA-452
Repository: aurora
Description
-------
Switching to rsync has the additional benefit of simplifying local development, since uncommitted files may be tested against in the environment.
In the course of this, i removed some redundant build steps done by the end-to-end tests.
Diffs
-----
examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8
src/test/sh/org/apache/aurora/e2e/flask/BUILD eaadcfccf1bb169656fca7f6245192a0a66e669a
src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora ad5aafec1f796baef766ed12b2a597f26997d5b3
src/test/sh/org/apache/aurora/e2e/flask/flask_example.py 0a01c0086f1ad2e7d3fc93f2baab572b5c22df5e
src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora 6d54463c349699946c2063385b1bd38a0f8c9e58
src/test/sh/org/apache/aurora/e2e/test_common.sh 1328ac50d3277d4a63ce72b01d1efbc385859284
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh c8fa07a5426c6c7748412062c26996b84637efb3
src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 3c4165c8464b42f7f5dc4f94a079ff7c3086cdbc
Diff: https://reviews.apache.org/r/21740/diff/
Testing
-------
bash examples/vagrant/test_tutorial.sh
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
I also downloaded the 0.5.0=RC0 and augmented the provisioning script to validate that the vagrant setup works there.
Thanks,
Bill Farner
Re: Review Request 21740: Use rsync instead of git to copy code into vagrant,
simplify end-to-end tests.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21740/#review43653
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On May 21, 2014, 12:50 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21740/
> -----------------------------------------------------------
>
> (Updated May 21, 2014, 12:50 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
>
>
> Bugs: AURORA-452
> https://issues.apache.org/jira/browse/AURORA-452
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Switching to rsync has the additional benefit of simplifying local development, since uncommitted files may be tested against in the environment.
>
> In the course of this, i removed some redundant build steps done by the end-to-end tests.
>
>
> Diffs
> -----
>
> examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8
> src/test/sh/org/apache/aurora/e2e/flask/BUILD eaadcfccf1bb169656fca7f6245192a0a66e669a
> src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora ad5aafec1f796baef766ed12b2a597f26997d5b3
> src/test/sh/org/apache/aurora/e2e/flask/flask_example.py 0a01c0086f1ad2e7d3fc93f2baab572b5c22df5e
> src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora 6d54463c349699946c2063385b1bd38a0f8c9e58
> src/test/sh/org/apache/aurora/e2e/test_common.sh 1328ac50d3277d4a63ce72b01d1efbc385859284
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh c8fa07a5426c6c7748412062c26996b84637efb3
> src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 3c4165c8464b42f7f5dc4f94a079ff7c3086cdbc
>
> Diff: https://reviews.apache.org/r/21740/diff/
>
>
> Testing
> -------
>
> Successfully ran:
> bash examples/vagrant/test_tutorial.sh
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
>
> I also downloaded the 0.5.0=RC0 and augmented the provisioning script to validate that the vagrant setup works there.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 21740: Use rsync instead of git to copy code into vagrant,
simplify end-to-end tests.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21740/
-----------------------------------------------------------
(Updated May 21, 2014, 7:50 p.m.)
Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
Changes
-------
Fixed v2 test script.
Bugs: AURORA-452
https://issues.apache.org/jira/browse/AURORA-452
Repository: aurora
Description
-------
Switching to rsync has the additional benefit of simplifying local development, since uncommitted files may be tested against in the environment.
In the course of this, i removed some redundant build steps done by the end-to-end tests.
Diffs (updated)
-----
examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8
src/test/sh/org/apache/aurora/e2e/flask/BUILD eaadcfccf1bb169656fca7f6245192a0a66e669a
src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora ad5aafec1f796baef766ed12b2a597f26997d5b3
src/test/sh/org/apache/aurora/e2e/flask/flask_example.py 0a01c0086f1ad2e7d3fc93f2baab572b5c22df5e
src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora 6d54463c349699946c2063385b1bd38a0f8c9e58
src/test/sh/org/apache/aurora/e2e/test_common.sh 1328ac50d3277d4a63ce72b01d1efbc385859284
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh c8fa07a5426c6c7748412062c26996b84637efb3
src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 3c4165c8464b42f7f5dc4f94a079ff7c3086cdbc
Diff: https://reviews.apache.org/r/21740/diff/
Testing (updated)
-------
Successfully ran:
bash examples/vagrant/test_tutorial.sh
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
I also downloaded the 0.5.0=RC0 and augmented the provisioning script to validate that the vagrant setup works there.
Thanks,
Bill Farner
Re: Review Request 21740: Use rsync instead of git to copy code into vagrant,
simplify end-to-end tests.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21740/#review43565
-----------------------------------------------------------
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
<https://reviews.apache.org/r/21740/#comment77806>
This TODO should be removed - run is working now.
- Mark Chu-Carroll
On May 20, 2014, 8:21 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21740/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 8:21 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
>
>
> Bugs: AURORA-452
> https://issues.apache.org/jira/browse/AURORA-452
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Switching to rsync has the additional benefit of simplifying local development, since uncommitted files may be tested against in the environment.
>
> In the course of this, i removed some redundant build steps done by the end-to-end tests.
>
>
> Diffs
> -----
>
> examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8
> src/test/sh/org/apache/aurora/e2e/flask/BUILD eaadcfccf1bb169656fca7f6245192a0a66e669a
> src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora ad5aafec1f796baef766ed12b2a597f26997d5b3
> src/test/sh/org/apache/aurora/e2e/flask/flask_example.py 0a01c0086f1ad2e7d3fc93f2baab572b5c22df5e
> src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora 6d54463c349699946c2063385b1bd38a0f8c9e58
> src/test/sh/org/apache/aurora/e2e/test_common.sh 1328ac50d3277d4a63ce72b01d1efbc385859284
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh c8fa07a5426c6c7748412062c26996b84637efb3
> src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 3c4165c8464b42f7f5dc4f94a079ff7c3086cdbc
>
> Diff: https://reviews.apache.org/r/21740/diff/
>
>
> Testing
> -------
>
> bash examples/vagrant/test_tutorial.sh
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
> I also downloaded the 0.5.0=RC0 and augmented the provisioning script to validate that the vagrant setup works there.
>
>
> *NOTE* There is still some work to do to get test_end_to_end_v2.sh, i will hold off submitting until that is in shape. Please don't hesitate to review other files, though.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 21740: Use rsync instead of git to copy code into vagrant,
simplify end-to-end tests.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21740/#review43566
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Chu-Carroll
On May 20, 2014, 8:21 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21740/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 8:21 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
>
>
> Bugs: AURORA-452
> https://issues.apache.org/jira/browse/AURORA-452
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Switching to rsync has the additional benefit of simplifying local development, since uncommitted files may be tested against in the environment.
>
> In the course of this, i removed some redundant build steps done by the end-to-end tests.
>
>
> Diffs
> -----
>
> examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8
> src/test/sh/org/apache/aurora/e2e/flask/BUILD eaadcfccf1bb169656fca7f6245192a0a66e669a
> src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora ad5aafec1f796baef766ed12b2a597f26997d5b3
> src/test/sh/org/apache/aurora/e2e/flask/flask_example.py 0a01c0086f1ad2e7d3fc93f2baab572b5c22df5e
> src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora 6d54463c349699946c2063385b1bd38a0f8c9e58
> src/test/sh/org/apache/aurora/e2e/test_common.sh 1328ac50d3277d4a63ce72b01d1efbc385859284
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh c8fa07a5426c6c7748412062c26996b84637efb3
> src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 3c4165c8464b42f7f5dc4f94a079ff7c3086cdbc
>
> Diff: https://reviews.apache.org/r/21740/diff/
>
>
> Testing
> -------
>
> bash examples/vagrant/test_tutorial.sh
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
> I also downloaded the 0.5.0=RC0 and augmented the provisioning script to validate that the vagrant setup works there.
>
>
> *NOTE* There is still some work to do to get test_end_to_end_v2.sh, i will hold off submitting until that is in shape. Please don't hesitate to review other files, though.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 21740: Use rsync instead of git to copy code into vagrant,
simplify end-to-end tests.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21740/
-----------------------------------------------------------
(Updated May 21, 2014, 12:21 a.m.)
Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
Bugs: AURORA-452
https://issues.apache.org/jira/browse/AURORA-452
Repository: aurora
Description
-------
Switching to rsync has the additional benefit of simplifying local development, since uncommitted files may be tested against in the environment.
In the course of this, i removed some redundant build steps done by the end-to-end tests.
Diffs
-----
examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8
src/test/sh/org/apache/aurora/e2e/flask/BUILD eaadcfccf1bb169656fca7f6245192a0a66e669a
src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora ad5aafec1f796baef766ed12b2a597f26997d5b3
src/test/sh/org/apache/aurora/e2e/flask/flask_example.py 0a01c0086f1ad2e7d3fc93f2baab572b5c22df5e
src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora 6d54463c349699946c2063385b1bd38a0f8c9e58
src/test/sh/org/apache/aurora/e2e/test_common.sh 1328ac50d3277d4a63ce72b01d1efbc385859284
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh c8fa07a5426c6c7748412062c26996b84637efb3
src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 3c4165c8464b42f7f5dc4f94a079ff7c3086cdbc
Diff: https://reviews.apache.org/r/21740/diff/
Testing
-------
bash examples/vagrant/test_tutorial.sh
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
I also downloaded the 0.5.0=RC0 and augmented the provisioning script to validate that the vagrant setup works there.
*NOTE* There is still some work to do to get test_end_to_end_v2.sh, i will hold off submitting until that is in shape. Please don't hesitate to review other files, though.
Thanks,
Bill Farner
Re: Review Request 21740: Use rsync instead of git to copy code into vagrant,
simplify end-to-end tests.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21740/
-----------------------------------------------------------
(Updated May 21, 2014, 12:20 a.m.)
Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
Bugs: AURORA-452
https://issues.apache.org/jira/browse/AURORA-452
Repository: aurora
Description
-------
Switching to rsync has the additional benefit of simplifying local development, since uncommitted files may be tested against in the environment.
In the course of this, i removed some redundant build steps done by the end-to-end tests.
Diffs
-----
examples/vagrant/provision-dev-cluster.sh 97bb877a029fc4c1f32811d0c53be2761fbffae8
src/test/sh/org/apache/aurora/e2e/flask/BUILD eaadcfccf1bb169656fca7f6245192a0a66e669a
src/test/sh/org/apache/aurora/e2e/flask/flask_example.aurora ad5aafec1f796baef766ed12b2a597f26997d5b3
src/test/sh/org/apache/aurora/e2e/flask/flask_example.py 0a01c0086f1ad2e7d3fc93f2baab572b5c22df5e
src/test/sh/org/apache/aurora/e2e/flask/flask_example_updated.aurora 6d54463c349699946c2063385b1bd38a0f8c9e58
src/test/sh/org/apache/aurora/e2e/test_common.sh 1328ac50d3277d4a63ce72b01d1efbc385859284
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh c8fa07a5426c6c7748412062c26996b84637efb3
src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 3c4165c8464b42f7f5dc4f94a079ff7c3086cdbc
Diff: https://reviews.apache.org/r/21740/diff/
Testing (updated)
-------
bash examples/vagrant/test_tutorial.sh
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
I also downloaded the 0.5.0=RC0 and augmented the provisioning script to validate that the vagrant setup works there.
*NOTE* There is still some work to do to get test_end_to_end_v2.sh, i will hold off submitting until that is in shape. Please don't hesitate to review other files, though.
Thanks,
Bill Farner