You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by "Roy T. Fielding" <fi...@kiwi.ICS.UCI.EDU> on 1997/05/21 21:17:22 UTC

Re: [BUG] SEGV in send_error_response

>I've attached a patch which solves this indirectly as noted above, but I
>think it might make more sense to replace r->err_headers_out with an empty
>table (via create_table) than to set it to NULL, as is done below.
><shrug>  I dunno; I don't know this section of code well enough to have a
>strong opinion one way or another.

I'd rather not allocate additional memory for it.  I guess what we could
do is add

void clear_table(table *t)
{
    t->nelts = 0;
}

or something similar (i.e., tested).  OTOH, it is probably a good idea
to apply your patch anyway, since many of the table variables are NULL
before they are allocated (and thus NULL should be considered an empty table).

....Roy   +1