You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@iotdb.apache.org by Christofer Dutz <ch...@c-ware.de> on 2019/01/17 09:51:54 UTC
What's the holdup with the code?
Hi,
still the IoTDB git repo ist empty … what’s the reason for this? Anything I can help with?
Chris
Re: What's the holdup with the code?
Posted by Justin Mclean <ju...@me.com>.
Hi,
> Everything doesn't have to be perfect before it comes here.
+1 to that you might even be able to find other people who want to help in those tasks.
Thanks,
Justin
Re: What's the holdup with the code?
Posted by Christofer Dutz <ch...@c-ware.de>.
Same here,
That way in a git blame you can always see why a line of code is the way it is by reading the last commit message as well as its history.
And you can always see who wrote wat part of code ... otherwise you'll be forever the one to blame for a lot of code you didn't write ;-)
Chris
Am 17.01.19, 13:46 schrieb "Kevin A. McGrail" <km...@apache.org>:
For me, my immediate reactio bnb is save the comments and pull everything
into the new repo.
On Thu, Jan 17, 2019, 07:44 Xiangdong Huang <sainthxd@gmail.com wrote:
> Hi,
>
> If we push the codes into Apache repository, should we remain all the
> existing commit history? I can do it by running `git remote add
> APACHE_REPOSITORY` and `git push` commands. The current git repository is
> about 11 MB, and there maybe some meaningless commit log messages in the
> repository.
>
> Another choice is running `git clone APACHE_REPOSITORY` to a folder first,
> copying all the codes to the folder second, and then `git add ./` and `git
> push`. If so, all the existing commitlogs are lost (but we can get a clean
> start.)
>
> Best,
>
>
>
>
>
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
>
> 黄向东
> 清华大学 软件学院
>
>
> Christofer Dutz <ch...@c-ware.de> 于2019年1月17日周四 下午7:42写道：
>
> > Hi,
> >
> > Everything doesn't have to be perfect before it comes here. Why not push
> > things over and clean up here?
> > And Checkstyle and Javadoc is definitely no blocker.
> >
> > Chris
> >
> >
> > Am 17.01.19, 12:23 schrieb "Xu yi" <xu...@126.com>:
> >
> > I’m sorry about that. We used check-style plugin which advises us to
> > change code style , add javadoc and so on. It takes some time to finish
> it.
> > We will push to apache repo this week if everything works as expected.
> >
> > Xu yi
> >
> > iPhoneから送信
> >
> > 2019/01/17 17:51、Christofer Dutz <ch...@c-ware.de>のメール:
> >
> > > Hi,
> > >
> > > still the IoTDB git repo ist empty … what’s the reason for this?
> > Anything I can help with?
> > >
> > > Chris
> >
> >
> >
> >
>
Re: What's the holdup with the code?
Posted by "Kevin A. McGrail" <km...@apache.org>.
For me, my immediate reactio bnb is save the comments and pull everything
into the new repo.
On Thu, Jan 17, 2019, 07:44 Xiangdong Huang <sainthxd@gmail.com wrote:
> Hi,
>
> If we push the codes into Apache repository, should we remain all the
> existing commit history? I can do it by running `git remote add
> APACHE_REPOSITORY` and `git push` commands. The current git repository is
> about 11 MB, and there maybe some meaningless commit log messages in the
> repository.
>
> Another choice is running `git clone APACHE_REPOSITORY` to a folder first,
> copying all the codes to the folder second, and then `git add ./` and `git
> push`. If so, all the existing commitlogs are lost (but we can get a clean
> start.)
>
> Best,
>
>
>
>
>
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
>
> 黄向东
> 清华大学 软件学院
>
>
> Christofer Dutz <ch...@c-ware.de> 于2019年1月17日周四 下午7:42写道：
>
> > Hi,
> >
> > Everything doesn't have to be perfect before it comes here. Why not push
> > things over and clean up here?
> > And Checkstyle and Javadoc is definitely no blocker.
> >
> > Chris
> >
> >
> > Am 17.01.19, 12:23 schrieb "Xu yi" <xu...@126.com>:
> >
> > I’m sorry about that. We used check-style plugin which advises us to
> > change code style , add javadoc and so on. It takes some time to finish
> it.
> > We will push to apache repo this week if everything works as expected.
> >
> > Xu yi
> >
> > iPhoneから送信
> >
> > 2019/01/17 17:51、Christofer Dutz <ch...@c-ware.de>のメール:
> >
> > > Hi,
> > >
> > > still the IoTDB git repo ist empty … what’s the reason for this?
> > Anything I can help with?
> > >
> > > Chris
> >
> >
> >
> >
>
Re: What's the holdup with the code?
Posted by Xiangdong Huang <sa...@gmail.com>.
Hi,
Thanks for all advice.
I have pushed the codes to the repository, though there are still some
checkstyle issues. (I will open some JIRA issues to records them, and
maybe there are some other issues).
Now, all guys can work on the apache repository.
Besides, please set the default branch as `master`. Thanks :D
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
吴晟 Sheng Wu <wu...@foxmail.com> 于2019年1月17日周四 下午9:06写道：
> I think we should keep all commit logs. 11MB is a very small repository in
> OSS.
>
>
> I suggest you could choose what is the strategy for future commits. Do
> `squash and merge` or `merge all commits`.
> That is also not about repository size, just for making the commit logs
> more meaningful.
>
>
> ------------------
> Sheng Wu
> Apache SkyWalking, ShardingSphere, Zipkin
> Twitter, wusheng1108
>
>
>
>
>
>
>
> ------------------ Original ------------------
> From: "Xiangdong Huang"<sa...@gmail.com>;
> Date: Thu, Jan 17, 2019 08:44 PM
> To: "dev"<de...@iotdb.apache.org>;
>
> Subject: Re: What's the holdup with the code?
>
>
>
> Hi,
>
> If we push the codes into Apache repository, should we remain all the
> existing commit history? I can do it by running `git remote add
> APACHE_REPOSITORY` and `git push` commands. The current git repository is
> about 11 MB, and there maybe some meaningless commit log messages in the
> repository.
>
> Another choice is running `git clone APACHE_REPOSITORY` to a folder first,
> copying all the codes to the folder second, and then `git add ./` and `git
> push`. If so, all the existing commitlogs are lost (but we can get a clean
> start.)
>
> Best,
>
>
>
>
>
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
>
> 黄向东
> 清华大学 软件学院
>
>
> Christofer Dutz <ch...@c-ware.de> 于2019年1月17日周四 下午7:42写道：
>
> > Hi,
> >
> > Everything doesn't have to be perfect before it comes here. Why not push
> > things over and clean up here?
> > And Checkstyle and Javadoc is definitely no blocker.
> >
> > Chris
> >
> >
> > Am 17.01.19, 12:23 schrieb "Xu yi" <xu...@126.com>:
> >
> > I’m sorry about that. We used check-style plugin which advises us to
> > change code style , add javadoc and so on. It takes some time to finish
> it.
> > We will push to apache repo this week if everything works as expected.
> >
> > Xu yi
> >
> > iPhoneから送信
> >
> > 2019/01/17 17:51、Christofer Dutz <ch...@c-ware.de>のメール:
> >
> > > Hi,
> > >
> > > still the IoTDB git repo ist empty … what’s the reason for this?
> > Anything I can help with?
> > >
> > > Chris
> >
> >
> >
> >
Re: What's the holdup with the code?
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I think we should keep all commit logs. 11MB is a very small repository in OSS.
Also +1 keeping the commit history is very important if any provenance issues ever come up.
Thanks,
Justin
Re: What's the holdup with the code?
Posted by 吴晟 Sheng Wu <wu...@foxmail.com>.
I think we should keep all commit logs. 11MB is a very small repository in OSS.
I suggest you could choose what is the strategy for future commits. Do `squash and merge` or `merge all commits`.
That is also not about repository size, just for making the commit logs more meaningful.
------------------
Sheng Wu
Apache SkyWalking, ShardingSphere, Zipkin
Twitter, wusheng1108
------------------ Original ------------------
From: "Xiangdong Huang"<sa...@gmail.com>;
Date: Thu, Jan 17, 2019 08:44 PM
To: "dev"<de...@iotdb.apache.org>;
Subject: Re: What's the holdup with the code?
Hi,
If we push the codes into Apache repository, should we remain all the
existing commit history? I can do it by running `git remote add
APACHE_REPOSITORY` and `git push` commands. The current git repository is
about 11 MB, and there maybe some meaningless commit log messages in the
repository.
Another choice is running `git clone APACHE_REPOSITORY` to a folder first,
copying all the codes to the folder second, and then `git add ./` and `git
push`. If so, all the existing commitlogs are lost (but we can get a clean
start.)
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Christofer Dutz <ch...@c-ware.de> 于2019年1月17日周四 下午7:42写道：
> Hi,
>
> Everything doesn't have to be perfect before it comes here. Why not push
> things over and clean up here?
> And Checkstyle and Javadoc is definitely no blocker.
>
> Chris
>
>
> Am 17.01.19, 12:23 schrieb "Xu yi" <xu...@126.com>:
>
> I’m sorry about that. We used check-style plugin which advises us to
> change code style , add javadoc and so on. It takes some time to finish it.
> We will push to apache repo this week if everything works as expected.
>
> Xu yi
>
> iPhoneから送信
>
> 2019/01/17 17:51、Christofer Dutz <ch...@c-ware.de>のメール:
>
> > Hi,
> >
> > still the IoTDB git repo ist empty … what’s the reason for this?
> Anything I can help with?
> >
> > Chris
>
>
>
>
Re: What's the holdup with the code?
Posted by Xiangdong Huang <sa...@gmail.com>.
Hi,
If we push the codes into Apache repository, should we remain all the
existing commit history? I can do it by running `git remote add
APACHE_REPOSITORY` and `git push` commands. The current git repository is
about 11 MB, and there maybe some meaningless commit log messages in the
repository.
Another choice is running `git clone APACHE_REPOSITORY` to a folder first,
copying all the codes to the folder second, and then `git add ./` and `git
push`. If so, all the existing commitlogs are lost (but we can get a clean
start.)
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Christofer Dutz <ch...@c-ware.de> 于2019年1月17日周四 下午7:42写道：
> Hi,
>
> Everything doesn't have to be perfect before it comes here. Why not push
> things over and clean up here?
> And Checkstyle and Javadoc is definitely no blocker.
>
> Chris
>
>
> Am 17.01.19, 12:23 schrieb "Xu yi" <xu...@126.com>:
>
> I’m sorry about that. We used check-style plugin which advises us to
> change code style , add javadoc and so on. It takes some time to finish it.
> We will push to apache repo this week if everything works as expected.
>
> Xu yi
>
> iPhoneから送信
>
> 2019/01/17 17:51、Christofer Dutz <ch...@c-ware.de>のメール:
>
> > Hi,
> >
> > still the IoTDB git repo ist empty … what’s the reason for this?
> Anything I can help with?
> >
> > Chris
>
>
>
>
Re: What's the holdup with the code?
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi,
Everything doesn't have to be perfect before it comes here. Why not push things over and clean up here?
And Checkstyle and Javadoc is definitely no blocker.
Chris
Am 17.01.19, 12:23 schrieb "Xu yi" <xu...@126.com>:
I’m sorry about that. We used check-style plugin which advises us to change code style , add javadoc and so on. It takes some time to finish it. We will push to apache repo this week if everything works as expected.
Xu yi
iPhoneから送信
2019/01/17 17:51、Christofer Dutz <ch...@c-ware.de>のメール:
> Hi,
>
> still the IoTDB git repo ist empty … what’s the reason for this? Anything I can help with?
>
> Chris
Re: What's the holdup with the code?
Posted by Xu yi <xu...@126.com>.
I’m sorry about that. We used check-style plugin which advises us to change code style , add javadoc and so on. It takes some time to finish it. We will push to apache repo this week if everything works as expected.
Xu yi
iPhoneから送信
2019/01/17 17:51、Christofer Dutz <ch...@c-ware.de>のメール:
> Hi,
>
> still the IoTDB git repo ist empty … what’s the reason for this? Anything I can help with?
>
> Chris