You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "zouyx (GitHub)" <gi...@apache.org> on 2020/01/22 08:19:33 UTC
[GitHub] [dubbo-go] zouyx opened pull request #336: Mod: License and
Notice
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
[ Full content available at: https://github.com/apache/dubbo-go/pull/336 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on issue #336: Mod: License and
Notice
Posted by "zouyx (GitHub)" <gi...@apache.org>.
I want to do that, but can not edit the release note, so the modification of markdown format can not be copied.
Will ask @fangyincheng for help π
[ Full content available at: https://github.com/apache/dubbo-go/pull/336 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on issue #336: Mod: License and
Notice
Posted by "zouyx (GitHub)" <gi...@apache.org>.
I want to do that, but can not edit the release note, so the markdown format can not be copied.
Will ask @fangyincheng for help π
[ Full content available at: https://github.com/apache/dubbo-go/pull/336 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks closed pull request #336: Mod: License
and Notice
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
[ pull request closed by AlexStocks ]
[ Full content available at: https://github.com/apache/dubbo-go/pull/336 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #336: Mod: License
and Notice
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/336?src=pr&el=h1) Report
> Merging [#336](https://codecov.io/gh/apache/dubbo-go/pull/336?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/1fa4bf6614cc722a1495d6a9e528513d4c692b49?src=pr&el=desc) will **increase** coverage by `0.62%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/336?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #336 +/- ##
===========================================
+ Coverage 65.53% 66.15% +0.62%
===========================================
Files 122 122
Lines 7562 7562
===========================================
+ Hits 4956 5003 +47
+ Misses 2117 2066 -51
- Partials 489 493 +4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/336?src=pr&el=tree) | Coverage Ξ | |
|---|---|---|
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/336/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0%> (-2.16%)` | :arrow_down: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/336/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `47.17% <0%> (-1.03%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/336/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `63.87% <0%> (-0.58%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/336/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `70.73% <0%> (+2.43%)` | :arrow_up: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/336/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `75.67% <0%> (+5.4%)` | :arrow_up: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/336/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `60.69% <0%> (+10.4%)` | :arrow_up: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/336/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `74.63% <0%> (+15.12%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/336?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/336?src=pr&el=footer). Last update [1fa4bf6...adf366a](https://codecov.io/gh/apache/dubbo-go/pull/336?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/336 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on issue #336: Mod: License and
Notice
Posted by "zouyx (GitHub)" <gi...@apache.org>.
I want to do that, but can not edit the release note, so can not copy the changes.
Will ask @fangyincheng for help π
[ Full content available at: https://github.com/apache/dubbo-go/pull/336 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org