You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/09 14:56:06 UTC
[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #5180: pthread: restore pthread mutex default protocol POSIX compatibility
hartmannathan commented on a change in pull request #5180:
URL: https://github.com/apache/incubator-nuttx/pull/5180#discussion_r780791275
##########
File path: sched/Kconfig
##########
@@ -658,6 +658,25 @@ config PTHREAD_MUTEX_DEFAULT_UNSAFE
endchoice # Default NORMAL mutex robustness
+choice
+ prompt "Default pthread mutex protocol"
+ default PTHREAD_MUTEX_DEFAULT_PRIO_NONE
+
+config PTHREAD_MUTEX_DEFAULT_PRIO_NONE
+ bool "PTHREAD_PRIO_NONE default"
+ ---help---
+ The default is the mutexes utilizing PTHREAD_PRIO_NONE protocol
+ (standard)
+
Review comment:
How about:
```
---help---
By default, pthread mutexes utilize PTHREAD_PRIO_NONE protocol (standard).
```
##########
File path: sched/Kconfig
##########
@@ -658,6 +658,25 @@ config PTHREAD_MUTEX_DEFAULT_UNSAFE
endchoice # Default NORMAL mutex robustness
+choice
+ prompt "Default pthread mutex protocol"
+ default PTHREAD_MUTEX_DEFAULT_PRIO_NONE
+
+config PTHREAD_MUTEX_DEFAULT_PRIO_NONE
+ bool "PTHREAD_PRIO_NONE default"
+ ---help---
+ The default is the mutexes utilizing PTHREAD_PRIO_NONE protocol
+ (standard)
+
+config PTHREAD_MUTEX_DEFAULT_PRIO_INHERIT
+ bool "PTHREAD_PRIO_INHERIT default"
+ depends on PRIORITY_INHERITANCE
+ ---help---
+ The default is the mutexes utilizing PTHREAD_PRIO_INHERIT protocol
+ (non-standard, but might be the choice for most of real-time systems)
+
Review comment:
How about:
```
---help---
By default, pthread mutexes utilize PTHREAD_PRIO_INHERIT protocol
(not POSIX-standard but a reasonable choice for most real-time systems).
```
or something along those lines?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org