You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tez.apache.org by GitBox <gi...@apache.org> on 2021/01/24 22:13:37 UTC
[GitHub] [tez] belugabehr opened a new pull request #90: TEZ-4267: Remove Superfluous Code from DAGAppMaster
belugabehr opened a new pull request #90:
URL: https://github.com/apache/tez/pull/90
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] jteagles merged pull request #90: TEZ-4267: Remove Superfluous Code from DAGAppMaster
Posted by GitBox <gi...@apache.org>.
jteagles merged pull request #90:
URL: https://github.com/apache/tez/pull/90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] belugabehr closed pull request #90: TEZ-4267: Remove Superfluous Code from DAGAppMaster
Posted by GitBox <gi...@apache.org>.
belugabehr closed pull request #90:
URL: https://github.com/apache/tez/pull/90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] belugabehr commented on a change in pull request #90: TEZ-4267: Remove Superfluous Code from DAGAppMaster
Posted by GitBox <gi...@apache.org>.
belugabehr commented on a change in pull request #90:
URL: https://github.com/apache/tez/pull/90#discussion_r563394261
##########
File path: tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java
##########
@@ -313,7 +311,6 @@
/**
* set of already executed dag names.
*/
- Set<String> dagNames = new HashSet<String>();
Review comment:
No references to this variable anywhere
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] hadoop-yetus commented on pull request #90: TEZ-4267: Remove Superfluous Code from DAGAppMaster
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #90:
URL: https://github.com/apache/tez/pull/90#issuecomment-871524472
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 12m 18s | master passed |
| +1 :green_heart: | compile | 0m 44s | master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 33s | master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 1m 11s | master passed |
| +1 :green_heart: | javadoc | 0m 44s | master passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 32s | master passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +0 :ok: | spotbugs | 1m 41s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 1m 40s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 26s | the patch passed |
| +1 :green_heart: | compile | 0m 30s | the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 30s | the patch passed |
| +1 :green_heart: | compile | 0m 24s | the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 24s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 18s | tez-dag: The patch generated 0 new + 53 unchanged - 1 fixed = 53 total (was 54) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 22s | the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 21s | the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | findbugs | 1m 8s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 4m 18s | tez-dag in the patch passed. |
| +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. |
| | | 27m 11s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-90/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/90 |
| JIRA Issue | TEZ-4267 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux 5a1ec7ed26ad 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 4684d06be |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-90/4/testReport/ |
| Max. process+thread count | 188 (vs. ulimit of 5500) |
| modules | C: tez-dag U: tez-dag |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-90/4/console |
| versions | git=2.25.1 maven=3.6.3 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] belugabehr commented on a change in pull request #90: TEZ-4267: Remove Superfluous Code from DAGAppMaster
Posted by GitBox <gi...@apache.org>.
belugabehr commented on a change in pull request #90:
URL: https://github.com/apache/tez/pull/90#discussion_r563394232
##########
File path: tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java
##########
@@ -2269,15 +2261,6 @@ public void handle(VertexEvent event) {
}
}
- private static void validateInputParam(String value, String param)
Review comment:
One used in one place. Limited value,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] belugabehr commented on a change in pull request #90: TEZ-4267: Remove Superfluous Code from DAGAppMaster
Posted by GitBox <gi...@apache.org>.
belugabehr commented on a change in pull request #90:
URL: https://github.com/apache/tez/pull/90#discussion_r563394232
##########
File path: tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java
##########
@@ -2269,15 +2261,6 @@ public void handle(VertexEvent event) {
}
}
- private static void validateInputParam(String value, String param)
Review comment:
One used in one place. Limited value,
##########
File path: tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java
##########
@@ -2269,15 +2261,6 @@ public void handle(VertexEvent event) {
}
}
- private static void validateInputParam(String value, String param)
Review comment:
Only used in one place. Limited value,
##########
File path: tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java
##########
@@ -313,7 +311,6 @@
/**
* set of already executed dag names.
*/
- Set<String> dagNames = new HashSet<String>();
Review comment:
No references to this variable anywhere
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] belugabehr commented on a change in pull request #90: TEZ-4267: Remove Superfluous Code from DAGAppMaster
Posted by GitBox <gi...@apache.org>.
belugabehr commented on a change in pull request #90:
URL: https://github.com/apache/tez/pull/90#discussion_r563394232
##########
File path: tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java
##########
@@ -2269,15 +2261,6 @@ public void handle(VertexEvent event) {
}
}
- private static void validateInputParam(String value, String param)
Review comment:
Only used in one place. Limited value,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org