You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2023/01/09 11:23:05 UTC
[GitHub] [orc] zhjwpku opened a new pull request, #1368: ORC-1352: [C++] get rid of ORC_NOEXCEPT/ORC_NULLPTR/ORC_OVERRIDE/ORC_…
zhjwpku opened a new pull request, #1368:
URL: https://github.com/apache/orc/pull/1368
…UNIQUE_PTR
the following macros could be removed from the main source code to make the code neat.
```
```
These macros should only be keeped in the `orc-config.hh.in` for backward compatiblity(in case any user use these marcros).
Signed-off-by: Junwang Zhao <zh...@gmail.com>
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of describing the problem.
3. Make PR title and description complete because these will be the permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1368: ORC-1352: [C++] get rid of ORC_NOEXCEPT/ORC_NULLPTR/ORC_OVERRIDE/ORC_…
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1368:
URL: https://github.com/apache/orc/pull/1368#discussion_r1064893930
##########
c++/include/orc/orc-config.hh.in:
##########
@@ -25,6 +25,7 @@
#include <stdint.h>
#endif
+// Following MACROS should be keeped for backward compatibility.
Review Comment:
Just a question. Do we have any deprecation process in Apache ORC C++, @wgtmac , @stiga-huang ?
I'm wondering when we can clean up these unused macros in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1368: ORC-1352: [C++] get rid of ORC_NOEXCEPT/ORC_NULLPTR/ORC_OVERRIDE/ORC_…
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1368:
URL: https://github.com/apache/orc/pull/1368#issuecomment-1375992292
Also, cc @williamhyun .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun closed pull request #1368: ORC-1352: [C++] Remove `ORC_[NOEXCEPT|NULLPTR|OVERRIDE|UNIQUE_PTR]` macro usages
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #1368: ORC-1352: [C++] Remove `ORC_[NOEXCEPT|NULLPTR|OVERRIDE|UNIQUE_PTR]` macro usages
URL: https://github.com/apache/orc/pull/1368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac commented on a diff in pull request #1368: ORC-1352: [C++] Remove `ORC_[NOEXCEPT|NULLPTR|OVERRIDE|UNIQUE_PTR]` macro usages
Posted by GitBox <gi...@apache.org>.
wgtmac commented on code in PR #1368:
URL: https://github.com/apache/orc/pull/1368#discussion_r1065269918
##########
c++/include/orc/orc-config.hh.in:
##########
@@ -25,6 +25,7 @@
#include <stdint.h>
#endif
+// Following MACROS should be keeped for backward compatibility.
Review Comment:
> Just a question. Do we have any deprecation process in Apache ORC C++, @wgtmac , @stiga-huang ? I'm wondering when we can clean up these unused macros in the future.
IMHO, these kinds of breaking change (e.g. remove deprecated stuff) can be included in a major release. C++14 adds the support of `[[deprecated]]` and we can leverage it to deal with the change of public API. But it is tricky to deal with macros (e.g. add a new macro at the compile time to enable the deprecated macros).
In short, we should keep backward compatibility until the next major release (e.g. v2.0.0) and let the downstream know anything is going to be deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1368: ORC-1352: [C++] Remove `ORC_[NOEXCEPT|NULLPTR|OVERRIDE|UNIQUE_PTR]` macro usages
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1368:
URL: https://github.com/apache/orc/pull/1368#discussion_r1065305782
##########
c++/include/orc/orc-config.hh.in:
##########
@@ -25,6 +25,7 @@
#include <stdint.h>
#endif
+// Following MACROS should be keeped for backward compatibility.
Review Comment:
Got it. Thank you. I agree with you. We can do that later separately if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org