You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by "Michael Watzek (JIRA)" <ji...@apache.org> on 2005/10/05 15:24:47 UTC
[jira] Created: (JDO-168) XML query testdata needs to be extended for new JDO 2 query tests
XML query testdata needs to be extended for new JDO 2 query tests
-----------------------------------------------------------------
Key: JDO-168
URL: http://issues.apache.org/jira/browse/JDO-168
Project: JDO
Type: Improvement
Components: tck20
Reporter: Michael Watzek
Assigned to: Michael Watzek
The new JDO 2 query test cases require more complex testdata than contained in 'companyForQueryTests.xml'. I propose to copy the content of 'companyAllRelationships.xml' into 'companyForQueryTests.xml'.
Due to this change some existing query tests must be adapted wrt the expected query result:
- test\java\org\apache\jdo\tck\query\jdoql\methods\SupportedCollectionMethods.java
- test\java\org\apache\jdo\tck\query\jdoql\NavigationThroughReferencesUsesDotOperator.java
- test\java\org\apache\jdo\tck\query\jdoql\Cast.java
- test\java\org\apache\jdo\tck\query\jdoql\DenoteUniquenessInFilter.java
- test\java\org\apache\jdo\tck\query\jdoql\NullCollectionsAndContainsMethod.java
- test\java\org\apache\jdo\tck\query\jdoql\operators\EqualityAndComparisonsBetweenDateFieldsAndParameters.java
- test\java\org\apache\jdo\tck\query\jdoql\operators\EqualityAndComparisonsBetweenStringFieldsAndParameters.java
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JDO-168) XML query testdata needs to be extended for new JDO 2 query tests
Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-168?page=comments#action_12331803 ]
Michael Bouschen commented on JDO-168:
--------------------------------------
I agree, the new JDO2 query tests require more test data.
The patch JDO-168.patch looks good!
> XML query testdata needs to be extended for new JDO 2 query tests
> -----------------------------------------------------------------
>
> Key: JDO-168
> URL: http://issues.apache.org/jira/browse/JDO-168
> Project: JDO
> Type: Improvement
> Components: tck20
> Reporter: Michael Watzek
> Assignee: Michael Watzek
> Attachments: JDO-168.patch
>
> The new JDO 2 query test cases require more complex testdata than contained in 'companyForQueryTests.xml'. I propose to copy the content of 'companyAllRelationships.xml' into 'companyForQueryTests.xml'.
> Due to this change some existing query tests must be adapted wrt the expected query result:
> - test\java\org\apache\jdo\tck\query\jdoql\methods\SupportedCollectionMethods.java
> - test\java\org\apache\jdo\tck\query\jdoql\NavigationThroughReferencesUsesDotOperator.java
> - test\java\org\apache\jdo\tck\query\jdoql\Cast.java
> - test\java\org\apache\jdo\tck\query\jdoql\DenoteUniquenessInFilter.java
> - test\java\org\apache\jdo\tck\query\jdoql\NullCollectionsAndContainsMethod.java
> - test\java\org\apache\jdo\tck\query\jdoql\operators\EqualityAndComparisonsBetweenDateFieldsAndParameters.java
> - test\java\org\apache\jdo\tck\query\jdoql\operators\EqualityAndComparisonsBetweenStringFieldsAndParameters.java
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (JDO-168) XML query testdata needs to be extended for new JDO 2 query tests
Posted by "Michael Watzek (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-168?page=all ]
Michael Watzek updated JDO-168:
-------------------------------
Attachment: JDO-168.patch
The patch fixes the issues above.
Applying this patch, JPOX returns two more failures with alltests.conf for both, application identity and datastore identity. The test cases NavigationThroughANullValuedField and NavigationThroughReferencesUsesDotOperator fail due to unexpected query results. JPOX generates an incomplete SQL statement for the query missing a discriminator comparison for a relationship navigation. For this reason, the query returns more results than expected. I'll file a separate issue.
> XML query testdata needs to be extended for new JDO 2 query tests
> -----------------------------------------------------------------
>
> Key: JDO-168
> URL: http://issues.apache.org/jira/browse/JDO-168
> Project: JDO
> Type: Improvement
> Components: tck20
> Reporter: Michael Watzek
> Assignee: Michael Watzek
> Attachments: JDO-168.patch
>
> The new JDO 2 query test cases require more complex testdata than contained in 'companyForQueryTests.xml'. I propose to copy the content of 'companyAllRelationships.xml' into 'companyForQueryTests.xml'.
> Due to this change some existing query tests must be adapted wrt the expected query result:
> - test\java\org\apache\jdo\tck\query\jdoql\methods\SupportedCollectionMethods.java
> - test\java\org\apache\jdo\tck\query\jdoql\NavigationThroughReferencesUsesDotOperator.java
> - test\java\org\apache\jdo\tck\query\jdoql\Cast.java
> - test\java\org\apache\jdo\tck\query\jdoql\DenoteUniquenessInFilter.java
> - test\java\org\apache\jdo\tck\query\jdoql\NullCollectionsAndContainsMethod.java
> - test\java\org\apache\jdo\tck\query\jdoql\operators\EqualityAndComparisonsBetweenDateFieldsAndParameters.java
> - test\java\org\apache\jdo\tck\query\jdoql\operators\EqualityAndComparisonsBetweenStringFieldsAndParameters.java
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JDO-168) XML query testdata needs to be extended for new JDO 2 query tests
Posted by "Michael Watzek (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-168?page=comments#action_12331384 ]
Michael Watzek commented on JDO-168:
------------------------------------
I filed JDO-169 describing the bug and the solution.
> XML query testdata needs to be extended for new JDO 2 query tests
> -----------------------------------------------------------------
>
> Key: JDO-168
> URL: http://issues.apache.org/jira/browse/JDO-168
> Project: JDO
> Type: Improvement
> Components: tck20
> Reporter: Michael Watzek
> Assignee: Michael Watzek
> Attachments: JDO-168.patch
>
> The new JDO 2 query test cases require more complex testdata than contained in 'companyForQueryTests.xml'. I propose to copy the content of 'companyAllRelationships.xml' into 'companyForQueryTests.xml'.
> Due to this change some existing query tests must be adapted wrt the expected query result:
> - test\java\org\apache\jdo\tck\query\jdoql\methods\SupportedCollectionMethods.java
> - test\java\org\apache\jdo\tck\query\jdoql\NavigationThroughReferencesUsesDotOperator.java
> - test\java\org\apache\jdo\tck\query\jdoql\Cast.java
> - test\java\org\apache\jdo\tck\query\jdoql\DenoteUniquenessInFilter.java
> - test\java\org\apache\jdo\tck\query\jdoql\NullCollectionsAndContainsMethod.java
> - test\java\org\apache\jdo\tck\query\jdoql\operators\EqualityAndComparisonsBetweenDateFieldsAndParameters.java
> - test\java\org\apache\jdo\tck\query\jdoql\operators\EqualityAndComparisonsBetweenStringFieldsAndParameters.java
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (JDO-168) XML query testdata needs to be extended for new JDO 2 query tests
Posted by "Michael Watzek (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-168?page=all ]
Michael Watzek resolved JDO-168:
--------------------------------
Resolution: Fixed
The patch has been checked in.
> XML query testdata needs to be extended for new JDO 2 query tests
> -----------------------------------------------------------------
>
> Key: JDO-168
> URL: http://issues.apache.org/jira/browse/JDO-168
> Project: JDO
> Type: Improvement
> Components: tck20
> Reporter: Michael Watzek
> Assignee: Michael Watzek
> Attachments: JDO-168.patch
>
> The new JDO 2 query test cases require more complex testdata than contained in 'companyForQueryTests.xml'. I propose to copy the content of 'companyAllRelationships.xml' into 'companyForQueryTests.xml'.
> Due to this change some existing query tests must be adapted wrt the expected query result:
> - test\java\org\apache\jdo\tck\query\jdoql\methods\SupportedCollectionMethods.java
> - test\java\org\apache\jdo\tck\query\jdoql\NavigationThroughReferencesUsesDotOperator.java
> - test\java\org\apache\jdo\tck\query\jdoql\Cast.java
> - test\java\org\apache\jdo\tck\query\jdoql\DenoteUniquenessInFilter.java
> - test\java\org\apache\jdo\tck\query\jdoql\NullCollectionsAndContainsMethod.java
> - test\java\org\apache\jdo\tck\query\jdoql\operators\EqualityAndComparisonsBetweenDateFieldsAndParameters.java
> - test\java\org\apache\jdo\tck\query\jdoql\operators\EqualityAndComparisonsBetweenStringFieldsAndParameters.java
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira