[GitHub] gianm commented on a change in pull request #6502: bloom filter sql

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #6502: bloom filter sql
URL: https://github.com/apache/incubator-druid/pull/6502#discussion_r234069933
 
 

 ##########
 File path: extensions-core/druid-bloom-filter/src/main/java/org/apache/druid/guice/BloomFilterExtensionModule.java
 ##########
 @@ -38,6 +40,9 @@
   @Override
   public void configure(Binder binder)
   {
-
+    if (binder != null) {
+      // Binder is null in some tests (apparently, idk i copied this from ApproximateHistogramModule).
 
 Review comment:
   The analogous ApproximateHistogramModule method is called with a null binder in a few of that package's tests. If you are doing that here too, ditch the idk from the comment, since now you know. If you're not doing it, remove the comment, and the `binder != null` check (since it won't be needed).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org