You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/05/04 05:45:20 UTC
[native-toolchain-CR] Remove unused versions of GCC
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18492
Change subject: Remove unused versions of GCC
......................................................................
Remove unused versions of GCC
The toolchain currently uses GCC 7.5, and it
builds GCC 8 and 9 additionally. These were intended
to be used to test upgrading the compiler. These
are not being used, so let's remove them and save
compilation time.
Change-Id: I651042d3b46ea26fbf8883c1a490614052953df1
---
M buildall.sh
1 file changed, 0 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/92/18492/1
--
To view, visit http://gerrit.cloudera.org:8080/18492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I651042d3b46ea26fbf8883c1a490614052953df1
Gerrit-Change-Number: 18492
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[native-toolchain-CR] Remove unused versions of GCC
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18492 )
Change subject: Remove unused versions of GCC
......................................................................
Patch Set 3: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/18492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I651042d3b46ea26fbf8883c1a490614052953df1
Gerrit-Change-Number: 18492
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 May 2022 22:46:03 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Remove unused versions of GCC
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18492 )
Change subject: Remove unused versions of GCC
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I651042d3b46ea26fbf8883c1a490614052953df1
Gerrit-Change-Number: 18492
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 04 May 2022 16:46:59 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Remove unused versions of GCC
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18492 )
Change subject: Remove unused versions of GCC
......................................................................
Remove unused versions of GCC
The toolchain currently uses GCC 7.5, and it
builds GCC 8 and 9 additionally. These were intended
to be used to test upgrading the compiler. These
are not being used, so let's remove them and save
compilation time.
Change-Id: I651042d3b46ea26fbf8883c1a490614052953df1
Reviewed-on: http://gerrit.cloudera.org:8080/18492
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M buildall.sh
1 file changed, 0 insertions(+), 10 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I651042d3b46ea26fbf8883c1a490614052953df1
Gerrit-Change-Number: 18492
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[native-toolchain-CR] Remove unused versions of GCC
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18492 )
Change subject: Remove unused versions of GCC
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I651042d3b46ea26fbf8883c1a490614052953df1
Gerrit-Change-Number: 18492
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 May 2022 04:03:53 +0000
Gerrit-HasComments: No