You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/02/26 07:11:57 UTC

[GitHub] [commons-collections] arturobernalg opened a new pull request #217: Add constant variable

arturobernalg opened a new pull request #217:
URL: https://github.com/apache/commons-collections/pull/217


   The idea it's reuse the constant variable in all the applications.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] arturobernalg commented on pull request #217: Add constant variable

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #217:
URL: https://github.com/apache/commons-collections/pull/217#issuecomment-786863415


   > Looks good to me. Following the pattern of the exiting `CollectionUtils.INDEX_NOT_FOUND`. 👍
   
   Thank you @kinow 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] kinow commented on pull request #217: COLLECTIONS-785 - Add constant variable

Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #217:
URL: https://github.com/apache/commons-collections/pull/217#issuecomment-790867789


   That was quick! I couldn't even finish my coffee :coffee: . Thanks @arturobernalg , let me update the JIRA/changes.xml and merge it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] arturobernalg commented on pull request #217: COLLECTIONS-785 - Add constant variable

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #217:
URL: https://github.com/apache/commons-collections/pull/217#issuecomment-790868691


   > That was quick! I couldn't even finish my coffee ☕ . Thanks @arturobernalg , let me update the JIRA/changes.xml and merge it.
   
   hahaha , take your time,
   
   TY


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] coveralls commented on pull request #217: Add constant variable

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #217:
URL: https://github.com/apache/commons-collections/pull/217#issuecomment-786469863


   
   [![Coverage Status](https://coveralls.io/builds/37472402/badge)](https://coveralls.io/builds/37472402)
   
   Coverage remained the same at 90.137% when pulling **9d89cf7b5c8db20a7db95c90250cb3e5ac940250 on arturobernalg:feature/constant** into **fdd78dc3e532ea8f60cbdce36dae0238362b5fef on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] arturobernalg commented on pull request #217: Add constant variable

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #217:
URL: https://github.com/apache/commons-collections/pull/217#issuecomment-790800098


   Hi @kinow 
   
   should i change something?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] kinow closed pull request #217: COLLECTIONS-785 - Add constant variable

Posted by GitBox <gi...@apache.org>.
kinow closed pull request #217:
URL: https://github.com/apache/commons-collections/pull/217


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] kinow commented on pull request #217: Add constant variable

Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #217:
URL: https://github.com/apache/commons-collections/pull/217#issuecomment-790860511


   > Hi @kinow
   > 
   > should i change something?
   
   Hi @arturobernalg sorry, I left it open to give time to others to review it, but also because I was going to create a JIRA. Even though it's a small change, I think it's OK to document it in the changelog (and add a thanks for your contribution there :-)
   
   Could you create the JIRA? I'll take care of the rest and merge it :+1: 
   
   Bruno


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-collections] arturobernalg commented on pull request #217: Add constant variable

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #217:
URL: https://github.com/apache/commons-collections/pull/217#issuecomment-790862656


   Hi @kinow 
   
   Jira created COLLECTIONS-785


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org