You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@httpd.apache.org by "William A. Rowe, Jr." <wr...@rowe-clan.net> on 2009/09/16 00:48:45 UTC

Re: svn commit: r815527 - /httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c

fuankg@apache.org wrote:
>      /* Special FTPOption that maps NLST directly to LIST */
> -    if (!is_list && (fsc->options & FTP_OPT_NLSTISLIST) || dashl) {
> +    if ((!is_list && (fsc->options & FTP_OPT_NLSTISLIST)) || dashl) {
>          is_list = 1;
>      }

Wouldn't this be

  if (!is_list && ((fsc->options & FTP_OPT_NLSTISLIST) || dashl)) {

as there is no point otherwise?  Actually we could drop the !is_list test,
considering that forced-override isn't harmful.

Re: svn commit: r815527 - /httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c

Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.

Guenter Knauf wrote:
> sorry, didnt look closely enough, please forgive - fixed with r815577.

No bother :)  Not sure it's worth rerolling for, but the other item you
pointed out might be more significant.  Looking at it.

Re: svn commit: r815527 - /httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c

Posted by Guenter Knauf <fu...@apache.org>.

Hi,
William A. Rowe, Jr. schrieb:
> Wouldn't this be
> 
>   if (!is_list && ((fsc->options & FTP_OPT_NLSTISLIST) || dashl)) {
> 
> as there is no point otherwise?  Actually we could drop the !is_list test,
> considering that forced-override isn't harmful.
sorry, didnt look closely enough, please forgive - fixed with r815577.

Gün.