You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by sl...@apache.org on 2008/04/15 11:32:48 UTC
svn commit: r648192 - in
/incubator/tuscany/java/sca/modules/implementation-java/src:
main/java/org/apache/tuscany/sca/implementation/java/introspect/impl/
test/java/org/apache/tuscany/sca/implementation/java/introspect/impl/
Author: slaws
Date: Tue Apr 15 02:32:43 2008
New Revision: 648192
URL: http://svn.apache.org/viewvc?rev=648192&view=rev
Log:
TUSCANY-2191. Committing Vamsi's patch to prevent an exception being raised for @Service with no parameters. This is just logged now. Thanks Vamsi
Modified:
incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/introspect/impl/ServiceProcessor.java
incubator/tuscany/java/sca/modules/implementation-java/src/test/java/org/apache/tuscany/sca/implementation/java/introspect/impl/ServiceProcessorTestCase.java
Modified: incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/introspect/impl/ServiceProcessor.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/introspect/impl/ServiceProcessor.java?rev=648192&r1=648191&r2=648192&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/introspect/impl/ServiceProcessor.java (original)
+++ incubator/tuscany/java/sca/modules/implementation-java/src/main/java/org/apache/tuscany/sca/implementation/java/introspect/impl/ServiceProcessor.java Tue Apr 15 02:32:43 2008
@@ -24,6 +24,7 @@
import java.lang.reflect.Method;
import java.lang.reflect.Type;
import java.util.Set;
+import java.util.logging.Logger;
import org.apache.tuscany.sca.assembly.AssemblyFactory;
import org.apache.tuscany.sca.assembly.Service;
@@ -46,6 +47,7 @@
* @version $Rev$ $Date$
*/
public class ServiceProcessor extends BaseJavaClassVisitor {
+ private static final Logger logger = Logger.getLogger(ServiceProcessor.class.getName());
private JavaInterfaceFactory javaFactory;
public ServiceProcessor(AssemblyFactory assemblyFactory, JavaInterfaceFactory javaFactory) {
@@ -76,7 +78,8 @@
if (interfaces.length == 0) {
Class<?> interfaze = annotation.value();
if (Void.class.equals(interfaze)) {
- throw new IllegalServiceDefinitionException("No interfaces specified");
+ //throw new IllegalServiceDefinitionException("No interfaces specified");
+ logger.warning("Ignoring @Service annotation. No interfaces specified. class = "+clazz.getName());
} else {
interfaces = new Class<?>[1];
interfaces[0] = interfaze;
Modified: incubator/tuscany/java/sca/modules/implementation-java/src/test/java/org/apache/tuscany/sca/implementation/java/introspect/impl/ServiceProcessorTestCase.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-java/src/test/java/org/apache/tuscany/sca/implementation/java/introspect/impl/ServiceProcessorTestCase.java?rev=648192&r1=648191&r2=648192&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/implementation-java/src/test/java/org/apache/tuscany/sca/implementation/java/introspect/impl/ServiceProcessorTestCase.java (original)
+++ incubator/tuscany/java/sca/modules/implementation-java/src/test/java/org/apache/tuscany/sca/implementation/java/introspect/impl/ServiceProcessorTestCase.java Tue Apr 15 02:32:43 2008
@@ -79,9 +79,9 @@
public void testNoInterfaces() throws Exception {
try {
processor.visitClass(BadDefinition.class, type);
- fail();
} catch (IllegalServiceDefinitionException e) {
- //expected
+ //not expected
+ fail();
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-commits-help@ws.apache.org