You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/21 20:17:18 UTC

[GitHub] [arrow-datafusion] andygrove opened a new pull request #919: Fix integration tests

andygrove opened a new pull request #919:
URL: https://github.com/apache/arrow-datafusion/pull/919


   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes https://github.com/apache/arrow-datafusion/issues/918
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   We want the tests to work
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   - Change some versions from 0.5.0-SNAPSHOT to 0.6.0
   - Upgrade Rust from 1.53 to 1.54
   - Comment out some use of cargo chef because I didn't know how to fix the errors with that
   - 
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   No
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove commented on a change in pull request #919: Fix integration tests

Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #919:
URL: https://github.com/apache/arrow-datafusion/pull/919#discussion_r693396719



##########
File path: dev/docker/ballista.dockerfile
##########
@@ -42,9 +42,9 @@ COPY datafusion-cli ./datafusion-cli/
 COPY datafusion-examples ./datafusion-examples/
 RUN cargo chef prepare --recipe-path recipe.json
 
-FROM base as cacher
-COPY --from=planner /tmp/ballista/recipe.json recipe.json
-RUN cargo chef cook $RELEASE_FLAG --recipe-path recipe.json
+# FROM base as cacher
+# COPY --from=planner /tmp/ballista/recipe.json recipe.json
+# RUN cargo chef cook $RELEASE_FLAG --recipe-path recipe.json

Review comment:
       I could use some help figuring out how to keep this working. See the issue for more details.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove merged pull request #919: Fix integration tests

Posted by GitBox <gi...@apache.org>.
andygrove merged pull request #919:
URL: https://github.com/apache/arrow-datafusion/pull/919


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] houqp commented on pull request #919: Fix integration tests

Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #919:
URL: https://github.com/apache/arrow-datafusion/pull/919#issuecomment-903297399


   LGTM, I will update the version bump automation as follow up PR to take care of these files going forward.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove commented on pull request #919: Fix integration tests

Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #919:
URL: https://github.com/apache/arrow-datafusion/pull/919#issuecomment-903280702


   Thanks for the help @houqp .. this is ready for review now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org