You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/04/28 00:10:44 UTC

[GitHub] [kafka] ableegoldman commented on a change in pull request #8564: KAFKA-9921: disable caching on stores configured to retain duplicates

ableegoldman commented on a change in pull request #8564:
URL: https://github.com/apache/kafka/pull/8564#discussion_r416233782



##########
File path: streams/src/main/java/org/apache/kafka/streams/state/internals/TimestampedWindowStoreBuilder.java
##########
@@ -56,6 +59,11 @@ public TimestampedWindowStoreBuilder(final WindowBytesStoreSupplier storeSupplie
                 store = new InMemoryTimestampedWindowStoreMarker(store);
             }
         }
+        if (storeSupplier.retainDuplicates()) {

Review comment:
       Good point. Pushed the change




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org