You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2019/07/24 23:21:13 UTC
[Impala-ASF-CR] Add support to tag docker images when pushing them
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13913
Change subject: Add support to tag docker images when pushing them
......................................................................
Add support to tag docker images when pushing them
This change adds an optional flag -t to docker/push-images.sh which
allows to specify a tag. Leaving it empty will omit adding a specific
tag and docker will fall back to "latest".
Testing: I tested this manually and confirmed that the flag works as
expected.
Change-Id: I370542127f190cc3e0be3facb3a0e691f101ef70
---
M docker/push-images.sh
1 file changed, 11 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/13913/1
--
To view, visit http://gerrit.cloudera.org:8080/13913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I370542127f190cc3e0be3facb3a0e691f101ef70
Gerrit-Change-Number: 13913
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] Add support to tag docker images when pushing them
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13913 )
Change subject: Add support to tag docker images when pushing them
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3987/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I370542127f190cc3e0be3facb3a0e691f101ef70
Gerrit-Change-Number: 13913
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jul 2019 23:41:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add support to tag docker images when pushing them
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13913 )
Change subject: Add support to tag docker images when pushing them
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I370542127f190cc3e0be3facb3a0e691f101ef70
Gerrit-Change-Number: 13913
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Jul 2019 23:22:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add support to tag docker images when pushing them
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13913 )
Change subject: Add support to tag docker images when pushing them
......................................................................
Patch Set 2: Verified+1 Code-Review+2
Rebased, carrying Tim's +2. This code doesn't get exercised in the tests and I validated it locally, so I'm marking it as Verified, too.
--
To view, visit http://gerrit.cloudera.org:8080/13913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I370542127f190cc3e0be3facb3a0e691f101ef70
Gerrit-Change-Number: 13913
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Jul 2019 18:22:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Add support to tag docker images when pushing them
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13913 )
Change subject: Add support to tag docker images when pushing them
......................................................................
Add support to tag docker images when pushing them
This change adds an optional flag -t to docker/push-images.sh which
allows to specify a tag. Leaving it empty will omit adding a specific
tag and docker will fall back to "latest".
Testing: I tested this manually and confirmed that the flag works as
expected.
Change-Id: I370542127f190cc3e0be3facb3a0e691f101ef70
Reviewed-on: http://gerrit.cloudera.org:8080/13913
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Lars Volker <lv...@cloudera.com>
---
M docker/push-images.sh
1 file changed, 11 insertions(+), 1 deletion(-)
Approvals:
Lars Volker: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I370542127f190cc3e0be3facb3a0e691f101ef70
Gerrit-Change-Number: 13913
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>