[GitHub] [tvm] cee1 commented on pull request #10801: [BYOC][ACL] Fix list is not supported as an input node

[GitBox <gi...@apache.org>]

cee1 commented on PR #10801:
URL: https://github.com/apache/tvm/pull/10801#issuecomment-1094546053

   > which have a list as inputs and offloading concatenate is a typical case of this issue.
   For src/runtime/contrib/json/json_runtime.h
   
   The JSONRuntimeBase misses a line for multiple EntryID (eid), as the patch pointed out.
   
   ( And this issue hits us while hooking ACL concat for a feature of "hot upgradable model":
     - "Hot upgradable model" are pure data, no executable code within it.
     - Which desire a common Op library to be used by ALL models.
   
   We leverage ACL as the base of the "common Op library". )
   
   Hi @lhutton1, is it a more appropriate way to
   a) Disable hooking to ACL' concat within relay/op/contrib/arm_compute_lib.py?  (While keeping the concat entry in runtime/contrib/arm_compute_lib/acl_runtime.cc)
   
   Or  b) Submit the fixup of json_runtime.h only?
   
   Any idea? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org