You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2014/04/15 22:57:31 UTC
[GitHub] couchdb pull request: [WIP] 2125 filter.db
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb/pull/210
[WIP] 2125 filter.db
Please do not merge, but take a look at ebc07d6:
Uses a new model to manage the state of the different search
filters to filter the view.
Nice feature: the filter for the database (upper input) and
the filters for the type (buttons) work nicely together,
so you can filter out all replications for that
database (let's name it registry) without the compaction,
if you choose replication as type and enter "registry" in the
top input.
Closes COUCHDB-2125
What's missing:
* some :heart: for the design of the input, can take a look at this on my own, but it's not my core competency
* a merge for the refactor which was the base for the feature (another PR, working on it with Garren), after the merge the diff should be just: ebc07d6
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb 2125-filter.db
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/210.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #210
----
commit 75f9a04e116fcee353e1d81dd61ff69867d868f5
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-04-06T16:17:36Z
Fauxton: reformat code & remove whitespace
commit 887f004ffbbb1ff04d2e7f686f17b0068228367c
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-04-06T21:15:16Z
Fauxton: refactor ActiveTasks
- do not use a model as a collection, directly operate on the
collection which gets filtered for the view
- remove the view which acted as layer to fetch collections from
the model and passed it to a view
- remove not used html-template
- format code
commit 7090bd51863f9be2bb588a399274a534946dff1a
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-04-06T21:42:04Z
Fauxton: do not load unnessecary d3 & backbone
commit 6eb09b59336e342c00d80c9c6859800d397d17e2
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-04-09T20:01:46Z
review
commit ebc07d6d9dbba5a74415fff0206cc2a007d3ed73
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-04-15T20:44:02Z
Implement a filter for databases
Uses a new model to manage the state of the different search
filters to filter the view.
Nice feature: the filter for the database (upper input) and
the filters for the type (buttons) work nicely together,
so you can filter out all replications for that
database (let's name it registry) without the compaction,
if you choose replication as type and enter "registry" in the
top input.
Closes COUCHDB-2125
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: [WIP] 2125 filter.db
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb/pull/210#issuecomment-43354413
That would be awesome!
I solved all conflicts and updated it as https://github.com/apache/couchdb/pull/203 was merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: [WIP] Implement a filter for databases - COU...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb/pull/210#issuecomment-50917488
ported to https://github.com/apache/couchdb-fauxton/pull/23
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: [WIP] Implement a filter for databases - COU...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb/pull/210
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: [WIP] 2125 filter.db
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb/pull/210#issuecomment-42812809
Maybe @deathbearbrown or @ocelotpotpie can help you clean up the design a little. Then I think we should merge it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---