You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/06 09:32:45 UTC

[GitHub] [incubator-mxnet] mseth10 commented on a change in pull request #17204: Enhancements for MXTensor for custom operators

mseth10 commented on a change in pull request #17204: Enhancements for MXTensor for custom operators
URL: https://github.com/apache/incubator-mxnet/pull/17204#discussion_r363216894
 
 

 ##########
 File path: include/mxnet/lib_api.h
 ##########
 @@ -277,6 +289,14 @@ struct MXTensor {
     return size;
   }
 
+  /*! \brief helper function to compare two MXTensors */
+  inline bool operator==(const MXTensor &oth) {
 
 Review comment:
   I agree with @wkcn on this. `isSame` is less confusing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services