You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/10/17 10:03:22 UTC
[GitHub] [jackrabbit-oak] joerghoh commented on a diff in pull request #715: OAK-9790 - Implement parallel indexing for speeding up oak run indexing command
joerghoh commented on code in PR #715:
URL: https://github.com/apache/jackrabbit-oak/pull/715#discussion_r996866172
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/progress/IndexingProgressReporter.java:
##########
@@ -229,10 +231,12 @@ public IndexUpdateState(String indexPath, boolean reindex, long estimatedCount)
}
public void indexUpdate() throws CommitFailedException {
- updateCount++;
- if (updateCount % 10000 == 0) {
- log.info("{} => Indexed {} nodes in {} ...", indexPath, updateCount, watch);
- watch.reset().start();
+ long count = updateCount.incrementAndGet();
+ if (count % 10000 == 0) {
+ synchronized (this) {
Review Comment:
Is there a need to synchronize this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org