[GitHub] zhijiangW opened a new pull request #6829: [FLINK-10367][network] Introduce NotificationResult for BufferListener to solve recursive stack overflow

[GitBox <gi...@apache.org>]

zhijiangW opened a new pull request #6829: [FLINK-10367][network] Introduce NotificationResult for BufferListener to solve recursive stack overflow
URL: https://github.com/apache/flink/pull/6829
 
 
   ## What is the purpose of the change
   
   *In the process of `LocalBufferPool#recycle`, the recycled buffer would be notified to a `BufferListener`. But this `BufferListener` may not need floating buffers any more currently, so this buffer is recycled again to the `LocalBufferPool`, then another `BufferListener` is selected to be notified of this available buffer.
   
   The above process may be repeatedly triggered in recursive way that will cause stack overflow error in extreme case. We ever encountered this error triggered by release all resources during task failover in large scale job, especially it will also result in buffer leak after stack overflow.*
   
   ## Brief change log
   
     - *Introduce the `NotificationResult` for describing the notification result for `BufferListener`*
     - *Adjust the process of `LocalBufferPool#recycle` to avoid recursive call*
     - *Adjust the process of `RemoteInputChannel#notifyBufferAvailable` accordingly*
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services