[GitHub] [hbase] Apache9 commented on a change in pull request #2378: HBASE-24929 Introduce a special CellComparator for master local region

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #2378:
URL: https://github.com/apache/hbase/pull/2378#discussion_r487699621



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -262,12 +264,9 @@
     "hbase.hregion.special.recovered.edits.dir";
 
   /**
-   * Whether to use {@link MetaCellComparator} even if we are not meta region. Used when creating
-   * master local region.
+   * The {@link CellComparator} class we want to use. Used when creating master local region.
    */
-  public static final String USE_META_CELL_COMPARATOR = "hbase.region.use.meta.cell.comparator";
-
-  public static final boolean DEFAULT_USE_META_CELL_COMPARATOR = false;
+  public static final String CELL_COMPARATOR_IMPL = "hbase.region.cell.comparator.impl";

Review comment:
       We need to set it in MasterRegion. And HRegion is IA.Private so no big problem?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org