[jira] [Commented] (HADOOP-11103) Clean up RemoteException

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-11103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347901#comment-14347901 ] 

Hadoop QA commented on HADOOP-11103:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12669533/HADOOP-11103.1.patch
  against trunk revision ed70fa1.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.namenode.TestFileTruncate

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5848//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5848//console

This message is automatically generated.

> Clean up RemoteException
> ------------------------
>
>                 Key: HADOOP-11103
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11103
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Trivial
>         Attachments: HADOOP-11103.1.patch
>
>
> RemoteException has a number of undocumented behaviors
> * o.a.h.ipc.RemoteException has no javadocs on getClassName. Reading the source, the String returned is the classname of the wrapped remote exception.
> * RemoteException(String, String) is equivalent to calling RemoteException(String, String, null)
> * Constructors allow null for all arguments
> * Some of the test code doesn't check for correct error codes to correspond with the wrapped exception type
> * methods don't document when they might return null



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)