You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "kezhenxu94 (via GitHub)" <gi...@apache.org> on 2026/06/16 06:17:40 UTC
[PR] build: bump go to 1.26 and golang base images to 1.26.4 [skywalking-satellite]
kezhenxu94 opened a new pull request, #263:
URL: https://github.com/apache/skywalking-satellite/pull/263
## Summary
- Bump `go.mod` go directive from 1.25.0 to 1.26.0
- Bump `docker/Dockerfile` build image from `golang:1.26.3` to `golang:1.26.4`
- Bump `test/e2e/base/satellite/Dockerfile` from `golang:1.25` to `golang:1.26`
## Test plan
- CI build and e2e tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build: bump go to 1.26 and golang base images to 1.26.4 [skywalking-satellite]
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 merged PR #263:
URL: https://github.com/apache/skywalking-satellite/pull/263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build: bump go to 1.26 and golang base images to 1.26.4 [skywalking-satellite]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #263:
URL: https://github.com/apache/skywalking-satellite/pull/263#discussion_r3418533547
##########
test/e2e/base/satellite/Dockerfile:
##########
@@ -14,7 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-FROM golang:1.25
+FROM golang:1.26
Review Comment:
`FROM golang:1.26` is a floating tag, which can drift to newer patch releases and potentially trigger Go toolchain auto-downloads (since `go.mod` pins `toolchain go1.26.4`) or introduce non-reproducible e2e images. Consider pinning the e2e base image to the same patch version used elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org