You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by yo...@apache.org on 2004/08/21 22:50:39 UTC

cvs commit: jakarta-commons/dbcp/src/java/org/apache/commons/dbcp BasicDataSource.java PoolingDataSource.java package.html

yoavs       2004/08/21 13:50:39

  Modified:    dbcp/src/java/org/apache/commons/dbcp BasicDataSource.java
                        PoolingDataSource.java package.html
  Log:
  JavaDoc enhancements to address Bugzilla 26062 and 30721.
  
  Revision  Changes    Path
  1.39      +3 -1      jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/BasicDataSource.java
  
  Index: BasicDataSource.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/BasicDataSource.java,v
  retrieving revision 1.38
  retrieving revision 1.39
  diff -u -r1.38 -r1.39
  --- BasicDataSource.java	11 Jul 2004 16:51:34 -0000	1.38
  +++ BasicDataSource.java	21 Aug 2004 20:50:39 -0000	1.39
  @@ -564,6 +564,8 @@
        * Return the login timeout (in seconds) for connecting to the database.
        *
        * @exception SQLException if a database access error occurs
  +     * @exception UnsupportedOperationException If the DataSource implementation
  +     *   does not support the login timeout feature.
        */
       public int getLoginTimeout() throws SQLException {
           return createDataSource().getLoginTimeout();
  
  
  
  1.14      +7 -7      jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/PoolingDataSource.java
  
  Index: PoolingDataSource.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/PoolingDataSource.java,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- PoolingDataSource.java	28 Feb 2004 12:18:17 -0000	1.13
  +++ PoolingDataSource.java	21 Aug 2004 20:50:39 -0000	1.14
  @@ -127,20 +127,20 @@
   
       /**
        * Throws {@link UnsupportedOperationException}.
  -     * Do this configuration within my {@link ObjectPool}.
  -     * @throws UnsupportedOperationException
  +     * @throws UnsupportedOperationException As this
  +     *   implementation does not support this feature.
        */
       public int getLoginTimeout() {
  -        throw new UnsupportedOperationException();
  +        throw new UnsupportedOperationException("Login timeout is not supported.");
       }
   
       /**
        * Throws {@link UnsupportedOperationException}.
  -     * Do this configuration within my {@link ObjectPool}.
  -     * @throws UnsupportedOperationException
  +     * @throws UnsupportedOperationException As this
  +     *   implementation does not support this feature.
        */
       public void setLoginTimeout(int seconds) {
  -        throw new UnsupportedOperationException();
  +        throw new UnsupportedOperationException("Login timeout is not supported.");
       }
   
       /**
  
  
  
  1.4       +2 -2      jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/package.html
  
  Index: package.html
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/dbcp/src/java/org/apache/commons/dbcp/package.html,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- package.html	24 Jun 2004 18:57:29 -0000	1.3
  +++ package.html	21 Aug 2004 20:50:39 -0000	1.4
  @@ -158,7 +158,7 @@
         <boolean value="true"/> <!-- test while idle -->
      </object>
      <!-- the next argument is the KeyedObjectPoolFactory -->
  -   <object class="org.apache.commons.pool.StackKeyedObjectPoolFactory">
  +   <object class="org.apache.commons.pool.impl.StackKeyedObjectPoolFactory">
         <int value="5"/> <!-- max idle -->
      </object>
      <string value="SELECT COUNT(*) FROM DUAL"/> <;!-- validation query -->
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org