You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/08 07:42:02 UTC
[GitHub] [flink-ml] yunfengzhou-hub opened a new pull request, #161: [FLINK-28571] Refractor API and Document of ChiSqTest
yunfengzhou-hub opened a new pull request, #161:
URL: https://github.com/apache/flink-ml/pull/161
## What is the purpose of the change
This PR aligns the behavior of ChiSqTest with that of Spark, and adds corresponding Python API and documents.
## Brief change log
- Change the input features of ChiSqTest from multiple arbitrary columns to one vector column
- Change the input label of ChiSqTest from arbitrary java object to numbers
- Add support for the flatten parameter in ChiSqTest
- Add module `stats` to Flink ML Python API
- Add ChiSqTest's Python implementation
- Add ChiSqTest's Java/Python example
- Add ChiSqTest's website document
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (docs & JavaDocs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] zhipeng93 merged pull request #161: [FLINK-28571] Improve API and Document of ChiSqTest
Posted by GitBox <gi...@apache.org>.
zhipeng93 merged PR #161:
URL: https://github.com/apache/flink-ml/pull/161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #161: [FLINK-28571] Improve API and Document of ChiSqTest
Posted by GitBox <gi...@apache.org>.
zhipeng93 commented on code in PR #161:
URL: https://github.com/apache/flink-ml/pull/161#discussion_r990731155
##########
docs/content/docs/operators/stats/chisqtest.md:
##########
@@ -0,0 +1,187 @@
+---
+title: "ChiSqTest"
+type: docs
+aliases:
+- /operators/stats/chisqtest.html
+---
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+## ChiSqTest
+
+Chi-square Test computes the statistics of independence of variables in a contingency table,
+e.g., p-value, and DOF(degree of freedom) for each input feature. The contingency table is
+constructed from the observed categorical values.
+
+### Input Columns
+
+| Param name | Type | Default | Description |
+|:------------|:-------|:-------------|:---------------------------|
+| featuresCol | Vector | `"features"` | The feature vector. |
Review Comment:
nit: could you remove `The` in the description to be consistent with existing docs?
Same for other params.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] zhipeng93 commented on pull request #161: [FLINK-28571] Improve API and Document of ChiSqTest
Posted by GitBox <gi...@apache.org>.
zhipeng93 commented on PR #161:
URL: https://github.com/apache/flink-ml/pull/161#issuecomment-1272706717
Thanks for the update. Merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org