svn commit: r1562288 - in /myfaces/trinidad/trunk/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change: BaseChangeManager.java ChangeManager.java

[jw...@apache.org]

Author: jwaldman
Date: Tue Jan 28 22:26:14 2014
New Revision: 1562288

URL: http://svn.apache.org/r1562288
Log:
TRINIDAD-2448 Optimize ChangeManager.createDocumentChange() implementation
Currently the implementation of org.apache.myfaces.trinidad.change ChangeManager.createDocumentChange( ComponentChange change) does not account for fact that the supplied ComponentChange implementation can also be implementing DocumentChange. Improvement is to do this check first, type cast the supplied component to DocumentChange and return. 
Thanks to Prakash Udupa for the patch

Modified:
    myfaces/trinidad/trunk/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/BaseChangeManager.java
    myfaces/trinidad/trunk/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/ChangeManager.java

Modified: myfaces/trinidad/trunk/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/BaseChangeManager.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/BaseChangeManager.java?rev=1562288&r1=1562287&r2=1562288&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/BaseChangeManager.java (original)
+++ myfaces/trinidad/trunk/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/BaseChangeManager.java Tue Jan 28 22:26:14 2014
@@ -130,17 +130,8 @@ abstract class BaseChangeManager extends
   {
     if (supportsDocumentPersistence(facesContext))
     {
-      DocumentChange docChange = null;
-if (compChange instanceof DocumentChange)
-      
-      {
-        docChange = (DocumentChange)compChange;
-      }
-      else
-      {
-        // try to get equivalent DocumentChange from ComponentChange
-        docChange = createDocumentChange(compChange);
-      }
+      // try to get equivalent DocumentChange from ComponentChange
+      DocumentChange docChange = createDocumentChange(compChange);
 
       if (docChange != null)
       {

Modified: myfaces/trinidad/trunk/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/ChangeManager.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/ChangeManager.java?rev=1562288&r1=1562287&r2=1562288&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/ChangeManager.java (original)
+++ myfaces/trinidad/trunk/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/ChangeManager.java Tue Jan 28 22:26:14 2014
@@ -66,6 +66,12 @@ public abstract class ChangeManager
   protected static DocumentChange createDocumentChange(
     ComponentChange change)
   {
+    // the supplied ComponentChange could implement DocumentChange
+    if (change instanceof DocumentChange)
+    {
+      return (DocumentChange)change;
+    }
+    
     Class<? extends ComponentChange> changeClass = change.getClass();
 
     Object converterObject = null;