You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by GitBox <gi...@apache.org> on 2021/08/09 09:02:48 UTC
[GitHub] [carbondata] Indhumathi27 opened a new pull request #4199: [WIP] Support DPP for carbon
Indhumathi27 opened a new pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199
### Why is this PR needed?
### What changes were proposed in this PR?
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the change and update document)
### Is any new testcase added?
- No
- Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [WIP] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-899484882
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/261/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [WIP] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-899400803
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4114/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [WIP] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-897007491
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5846/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#discussion_r692845786
##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertIntoHadoopFsRelationCommand.scala
##########
@@ -199,7 +199,7 @@ case class CarbonInsertIntoHadoopFsRelationCommand(
// refresh cached files in FileIndex
fileIndex.foreach(_.refresh())
// refresh data cache if table is cached
- sparkSession.catalog.refreshByPath(outputPath.toString)
+ // sparkSession.catalog.refreshByPath(outputPath.toString)
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] asfgit closed pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [WIP] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-895139616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-906311419
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/298/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on a change in pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#discussion_r692846218
##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonDataSourceScan.scala
##########
@@ -49,9 +50,19 @@ case class CarbonDataSourceScan(
directScanSupport: Boolean,
@transient extraRDD: Option[(RDD[InternalRow], Boolean)] = None,
tableIdentifier: Option[TableIdentifier] = None,
+ @transient selectedCatalogPartitions : Seq[CatalogTablePartition] = Seq.empty,
+ @transient partitions: Seq[SparkExpression],
Review comment:
partitionFilters - does not have Dynamic subquery expression. Renamed the variables
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kunal642 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-909182257
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-909290457
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5904/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-906315797
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5897/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [WIP] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-897730302
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5849/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [WIP] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-898439653
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4109/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-904608069
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5882/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-908957400
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/304/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-906194774
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5895/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-909295226
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4160/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [WIP] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-899685094
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/262/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [WIP] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-895145420
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/237/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [WIP] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-900211564
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5863/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [WIP] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-899692121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-904633316
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/284/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-908956546
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5902/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-906227816
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [WIP] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-899385746
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/260/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [WIP] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-899390409
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5857/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [WIP] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-899489876
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4115/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-901251295
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4128/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kunal642 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-908896753
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [WIP] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-898434452
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/257/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-902662041
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/279/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-904616648
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4139/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-906101056
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-908923488
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4159/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [WIP] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-898436439
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5853/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-909287088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kunal642 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-908896753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-901338506
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/273/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] QiangCai commented on a change in pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
QiangCai commented on a change in pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#discussion_r692701424
##########
File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/dblocation/DBLocationCarbonTableTestCase.scala
##########
@@ -268,7 +268,7 @@ class DBLocationCarbonTableTestCase extends QueryTest with BeforeAndAfterEach {
}
test("Alter table drop column test") {
- sql(s"create database carbon location '$dbLocation'")
+ sql(s"create database carbon location '$dbLocation + /newdb/'")
Review comment:
no need +
##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertIntoHadoopFsRelationCommand.scala
##########
@@ -199,7 +199,7 @@ case class CarbonInsertIntoHadoopFsRelationCommand(
// refresh cached files in FileIndex
fileIndex.foreach(_.refresh())
// refresh data cache if table is cached
- sparkSession.catalog.refreshByPath(outputPath.toString)
+ // sparkSession.catalog.refreshByPath(outputPath.toString)
Review comment:
1. why commented it?
2. if no need already, remove it directly.
##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonDataSourceScan.scala
##########
@@ -49,9 +50,19 @@ case class CarbonDataSourceScan(
directScanSupport: Boolean,
@transient extraRDD: Option[(RDD[InternalRow], Boolean)] = None,
tableIdentifier: Option[TableIdentifier] = None,
+ @transient selectedCatalogPartitions : Seq[CatalogTablePartition] = Seq.empty,
+ @transient partitions: Seq[SparkExpression],
Review comment:
what are the different points between "partitionFilters" and "partitions"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-901316218
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5870/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-902670110
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4134/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kunal642 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-909933376
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-902666500
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5877/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [WIP] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-899486957
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/5858/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [WIP] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-897772967
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/253/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [WIP] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-896991003
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4102/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-906161353
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/296/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kunal642 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-909182257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-906197257
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4151/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-901251295
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4128/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kunal642 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-905366341
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-909287088
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/306/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-904518694
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-908923488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [WIP] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-897014726
Build Failed with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/250/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] asfgit closed pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [WIP] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-900219719
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/266/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [WIP] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-897715609
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4105/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] Indhumathi27 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
Indhumathi27 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-903586535
@QiangCai Handled the comments. Please help to review and merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [WIP] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-900223946
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4121/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4199: [CARBONDATA-4271] Support DPP for carbon
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#issuecomment-906332757
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4153/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org