You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/11/02 02:29:56 UTC

[GitHub] [dolphinscheduler] hstdream commented on a diff in pull request #12636: [Bug] [API]After we delete the worker group, but this task group still keep in the task setting.

hstdream commented on code in PR #12636:
URL: https://github.com/apache/dolphinscheduler/pull/12636#discussion_r1011091110


##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessDefinitionMapper.xml:
##########
@@ -195,4 +195,17 @@
         SELECT DISTINCT(id) as project_id
         FROM t_ds_project
     </select>
+    <select id="queryProcessDefinitionByWorkerGroupName" resultType="org.apache.dolphinscheduler.dao.entity.ProcessDefinition">
+        SELECT DISTINCT
+            pd.id, pd.code, pd.name
+        FROM
+            t_ds_process_task_relation ptr
+        JOIN t_ds_process_definition pd ON ptr.process_definition_code = pd.CODE
+        AND ptr.process_definition_version = pd.version
+        AND ptr.project_code = pd.project_code
+        JOIN t_ds_task_definition td ON ( ptr.pre_task_code = td.CODE AND ptr.pre_task_version = td.version )

Review Comment:
   Thanks for the comments, but if the workflow in the online is deleted from the workergroup, it will cause the workflow to fail to run . cc @ruanwenjun @SbloodyS @caishunfeng .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org