You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2018/06/27 20:45:06 UTC

[Bug 62500] New: Add Shell Script to Create CATALINA_BASE Directories

https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

            Bug ID: 62500
           Summary: Add Shell Script to Create CATALINA_BASE Directories
           Product: Tomcat 9
           Version: unspecified
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Packaging
          Assignee: dev@tomcat.apache.org
          Reporter: isapir@apache.org
  Target Milestone: -----

Add a batch/shell script, e.g. mkdirs-base.bat/sh, that will accept a target
directory as an argument and in it will create a directory structure for
CATALINA_BASE, i.e. conf, logs, temp, webapps, work.

Creating ticket per
http://tomcat.10.x6.nabble.com/Tomcat-Installation-on-Windows-tp5075398p5075436.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

--- Comment #7 from Igal Sapir <is...@apache.org> ---
(In reply to Michael Osipov from comment #4)
> (In reply to Igal Sapir from comment #3)
> > > Shall I share?
> > 
> > Sure, why not :)
> 
> Will do tomorrow as soon as I get access to our company's Subversion server.

Michael, I just realized that you are a committer.  If you want to take this
one yourself then that's fine by me - please let me know.  

Otherwise I will take your files and edit if/as needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

Christopher Schultz <ch...@christopherschultz.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35996|application/x-shellscript   |text/plain
          mime type|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

--- Comment #2 from Michael Osipov <19...@gmx.net> ---
Funny, I have crated such a script for two operating systems at work. My script
does even check for bound ports. Shall I share?

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

--- Comment #12 from Christopher Schultz <ch...@christopherschultz.net> ---
I usually do all this with (prepare yourselves, everyone) Apache ant as a part
of my build process.

On a a fresh machine where Java, ant, and Subversion are installed, my build
process is:

1. Create a master ~/.ant.properties (or copy from another host)
2. svn checkout
3. cd
4. ant install

Done.

This works well for us and our services, but it may not work for everyone,
which is why I never bothered to package it all up and give it away.

Plus it's not all Docker'd and Maven'd up, so the cool kids won't like it. Oh,
yeah, and get off my lawn.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

--- Comment #3 from Igal Sapir <is...@apache.org> ---
> Shall I share?

Sure, why not :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

--- Comment #11 from Michael Osipov <19...@gmx.net> ---
(In reply to Igal Sapir from comment #7)
> (In reply to Michael Osipov from comment #4)
> > (In reply to Igal Sapir from comment #3)
> > > > Shall I share?
> > > 
> > > Sure, why not :)
> > 
> > Will do tomorrow as soon as I get access to our company's Subversion server.
> 
> Michael, I just realized that you are a committer.  If you want to take this
> one yourself then that's fine by me - please let me know.  
> 
> Otherwise I will take your files and edit if/as needed.

Not necessary, you raised the issue. Attached my scripts and a sample
server.xml I use for filtering. Scripts only differ for platform specific
things and stuff I need at work, but 90 % are reusable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

--- Comment #15 from Christopher Schultz <ch...@christopherschultz.net> ---
(In reply to Igal Sapir from comment #13)
> While I could live with `ant`, I'd hate to make `Subversion` a requirement
> here (or anywhere, for that matter).

Oh, sure. I wasn't suggesting that /any/ revision-control system be a part of
any kind of "assisted build" that Tomcat might provide. I was just pointing-out
that it's very possible to build a CATALINA_BASE on depand as a part of an
application-installation process.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

Igal Sapir <is...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #16 from Igal Sapir <is...@apache.org> ---
I added the scripts `makebase.bat` and `makebase.sh` in
http://svn.apache.org/viewvc?view=revision&revision=1834798

The scripts are documented with comments.  I am not sure if there are other
places where documentation is required.

I'd be happy to add docs or modify script names and/or contents if needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

--- Comment #4 from Michael Osipov <19...@gmx.net> ---
(In reply to Igal Sapir from comment #3)
> > Shall I share?
> 
> Sure, why not :)

Will do tomorrow as soon as I get access to our company's Subversion server.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

--- Comment #9 from Michael Osipov <19...@gmx.net> ---
Created attachment 35996
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35996&action=edit
Create instance on FreeBSD

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

Christopher Schultz <ch...@christopherschultz.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35995|application/x-shellscript   |text/plain
          mime type|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

Igal Sapir <is...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from Igal Sapir <is...@apache.org> ---
How can I assign this ticket to myself?  If can not due to permissions, then
please someone with permissions do so.  Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

--- Comment #6 from Igal Sapir <is...@apache.org> ---
(In reply to Mark Thomas from comment #5)
> We don't assign tickets in Bugzilla. They are hard-coded to be assigned to
> the relevant dev@ list so any updates to the issue appear on list.
> 
> If you, want you can just add a note to the ticket that you are working on
> it.

Sounds good.

I am working on this ticket.  Will wait for feedback from Michael Osipov as per
comment #2 first.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

--- Comment #13 from Igal Sapir <is...@apache.org> ---
(In reply to Christopher Schultz from comment #12)
> I usually do all this with (prepare yourselves, everyone) Apache ant as a
> part of my build process.
> 
> On a a fresh machine where Java, ant, and Subversion are installed, my build
> process is:
> 
> 1. Create a master ~/.ant.properties (or copy from another host)
> 2. svn checkout
> 3. cd
> 4. ant install

While I could live with `ant`, I'd hate to make `Subversion` a requirement here
(or anywhere, for that matter).

I'm thinking of simple batch & shell scripts, that will use `mkdir` and `cp` to
create and copy the relevant files, so that when you're in working directory
${CATALINA_HOME}/bin you can run:

mkdirs-base <path-to-new-directory>

> Plus it's not all Docker'd and Maven'd up, so the cool kids won't like it.
> Oh, yeah, and get off my lawn.

LOL

+1 for Maven and +1 for Docker (for a total of +2)

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

--- Comment #5 from Mark Thomas <ma...@apache.org> ---
(In reply to Igal Sapir from comment #1)
> How can I assign this ticket to myself?  If can not due to permissions, then
> please someone with permissions do so.  Thank you.

We don't assign tickets in Bugzilla. They are hard-coded to be assigned to the
relevant dev@ list so any updates to the issue appear on list.

If you, want you can just add a note to the ticket that you are working on it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

--- Comment #8 from Michael Osipov <19...@gmx.net> ---
Created attachment 35995
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35995&action=edit
Create instance on HP-UX

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

--- Comment #10 from Michael Osipov <19...@gmx.net> ---
Created attachment 35997
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35997&action=edit
Sample server.xml for filtering with sed(1)

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

--- Comment #14 from William L Thomson Jr <wl...@o-sinc.com> ---
Please stick with a shell script. This could be useful on Gentoo. Where Tomcat
does have support for instances, but needs such a script to create them. The
old way uses an instance manager
https://gitweb.gentoo.org/repo/gentoo.git/tree/www-servers/tomcat/files/tomcat-instance-manager-r2.bash

The new way is different, but still needs something like is being discussed to
create the CATALINA_BASE for any instance. For time being I create the initial
instance within the package itself.
https://github.com/Obsidian-StudiosInc/os-xtoo/blob/master/www-servers/tomcat/tomcat-9999.ebuild#L183

This could be integrated with the init script to create a instance on the fly,
by creating a symlink to the tomcat init script with the instance name.
https://github.com/Obsidian-StudiosInc/os-xtoo/blob/master/www-servers/tomcat/files/tomcat.init#L9

Thus a plain old shell script would be most preferred, as it can be integrated
into many things, initial install, init script, users could invoke, etc.

Not sure if you all want to add a clean up section like is in the old instance
manager on Gentoo. Maybe able to use some of that, though a fair amount is
Gentoo specific.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org