You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "xianjingfeng (via GitHub)" <gi...@apache.org> on 2023/12/01 02:15:21 UTC
Re: [PR] [#960][part-4] feat(dashboard): Fix some display bugs and optimize the display format. [incubator-uniffle]
xianjingfeng commented on code in PR #1326:
URL: https://github.com/apache/incubator-uniffle/pull/1326#discussion_r1411522168
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/web/resource/ApplicationResource.java:
##########
@@ -46,9 +45,12 @@ public class ApplicationResource extends BaseResource {
public Response<Map<String, Integer>> getAppTotality() {
return execute(
() -> {
- Set<String> appIds = getApplicationManager().getAppIds();
Map<String, Integer> appTotalityMap = new HashMap<>();
- appTotalityMap.put("appTotality", appIds.size());
+ if (getApplicationManager().getQuotaManager() != null) {
+ appTotalityMap.put(
+ "appTotality",
+ getApplicationManager().getQuotaManager().getAppIdToUser().keySet().size());
Review Comment:
The following code have the same problem. @yl09099
https://github.com/apache/incubator-uniffle/blob/800bf159479e96c6f1911f827e818d3de71e8b51/coordinator/src/main/java/org/apache/uniffle/coordinator/web/resource/ApplicationResource.java#L62
https://github.com/apache/incubator-uniffle/blob/800bf159479e96c6f1911f827e818d3de71e8b51/coordinator/src/main/java/org/apache/uniffle/coordinator/web/resource/ApplicationResource.java#L81-L83
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org