[GitHub] piiswrong commented on a change in pull request #8578: Add development instructions and update installation instructions

[GitBox <gi...@apache.org>]

piiswrong commented on a change in pull request #8578: Add development instructions and update installation instructions
URL: https://github.com/apache/incubator-mxnet/pull/8578#discussion_r150134926
 
 

 ##########
 File path: docs/install/index.md
 ##########
 @@ -1062,58 +1082,35 @@ Install these dependencies using the following commands in any directory:
 
 ```bash
     sudo apt-get update
-    sudo apt-get -y install git build-essential libatlas-base-dev libopencv-dev graphviz python-pip
+    sudo apt-get -y install git build-essential libatlas-base-dev libopencv-dev graphviz python-pip cmake ninja-build
     sudo pip install pip --upgrade
     sudo pip install setuptools numpy --upgrade
     sudo pip install graphviz jupyter
 ```
 
-Clone the MXNet source code repository using the following ```git``` command in your home directory:
-```bash
-    git clone https://github.com/dmlc/mxnet.git --recursive
-    cd mxnet
-```
-
-Edit the Makefile to install the MXNet with CUDA bindings to leverage the GPU on the Jetson:
-```bash
-    cp make/config.mk .
-    echo "USE_CUDA=1" >> config.mk    
-    echo "USE_CUDA_PATH=/usr/local/cuda" >> config.mk
-    echo "USE_CUDNN=1" >> config.mk
-```
-
-Edit the Mshadow Makefile to ensure MXNet builds with Pascal's hardware level low precision acceleration by editing mshadow/make/mshadow.mk and adding the following after line 122:
+Clone and build MXNet using the following commands:
 ```bash
-MSHADOW_CFLAGS += -DMSHADOW_USE_PASCAL=1
-```
-
-Now you can build the complete MXNet library with the following command:
-```bash
-    make -j $(nproc)
+$ git clone --recursive https://github.com/dmlc/mxnet
+$ cd mxnet
+$ mkdir -p build && cd build
+$ cmake -DMSHADOW_USE_PASCAL=1 -GNinja ..
+$ ninja
 ```
 
-Executing this command creates a file called ```libmxnet.so``` in the mxnet/lib directory.
+Executing this command creates a file called ```libmxnet.so``` in the build/ directory.
 
 **Step 2** Install MXNet Python Bindings
 
 To install python bindings run the following commands in the MXNet directory:
 
 ```bash
+    cp build/libmxnet.* python/mxnet
 
 Review comment:
   This shouldn't be necessary

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services