[jira] [Commented] (CXF-6127) Check entire cause chain for SOAPFaultException

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230585#comment-14230585 ] 

ASF GitHub Bot commented on CXF-6127:
-------------------------------------

GitHub user kylape opened a pull request:

    https://github.com/apache/cxf/pull/34

    [CXF-6127] Check entire cause chain for SOAPFaultException to populate s...

    ...ubcodes and locale

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kylape/cxf cxf-6127

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cxf/pull/34.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #34
    
----
commit 65e0770cf0ec3ee0a397340f5d45caedd94693d7
Author: Kyle Lape <ky...@redhat.com>
Date:   2014-12-01T22:34:23Z

    [CXF-6127] Check entire cause chain for SOAPFaultException to populate subcodes and locale

----


> Check entire cause chain for SOAPFaultException
> -----------------------------------------------
>
>                 Key: CXF-6127
>                 URL: https://issues.apache.org/jira/browse/CXF-6127
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-WS Runtime
>            Reporter: Kyle Lape
>
> Section 10.2.2.3 of JAX-WS 2.2 spec has a footnote that says:
> bq. If the exception is a SOAPFaultException or has a cause that is a SOAPFaultException.
> Currently CXF only checks if the thrown exception is of the exact type (i.e. not a subtype of) {{SOAPFaultException}}.  We need to check all causes and may as well use {{instanceof}} rather than {{ex.getClass().equals(SOAPFaultException.class)}} in {{WebFaultOutInterceptor}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)