[GitHub] [spark] hddong commented on issue #25412: [SPARK-28691][EXAMPLES] DirectKafkaWordCount supoort kafka with kerberos

[GitBox <gi...@apache.org>]

hddong commented on issue #25412: [SPARK-28691][EXAMPLES] DirectKafkaWordCount supoort kafka with kerberos
URL: https://github.com/apache/spark/pull/25412#issuecomment-520322215
 
 
   > Hi, @hddong . Thank you for making a PR.
   > 
   > * Since `DirectKafkaWordCount.scala` and `JavaDirectKafkaWordCount.java` is a pair for language parity, this PR should update them together consistently.
   > * And, just out of curiosity, why do you want to have a Kerberized example at `DirectKafkaWordCount`? Do you want to change another examples like `StructuredKafkaWordCount.scala`, too?
   
   1. `JavaDirectKafkaWordCount.java`  done. 
   
   2. Most of our environment is Kerberized, when we do test if sparkstreaming can read from kafka normally in some case, we need to copy one more jar from somewhere else. So, I think it will be convenient if examples can test by default.
   
   3. I'm glad to change other like `StructuredKafkaWordCount.scala` , I will make a new PR later

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org