You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/19 14:22:15 UTC

[GitHub] [cloudstack] weizhouapache commented on pull request #4575: Enhance log messages with host name

weizhouapache commented on pull request #4575:
URL: https://github.com/apache/cloudstack/pull/4575#issuecomment-782105463


   @GabrielBrascher it would be good to add host name in the output.
   
   ip is not very important as we normally ssh into server using hostname, not ip.
   
   ```
   diff --git a/engine/schema/src/main/java/com/cloud/host/HostVO.java b/engine/schema/src/main/java/com/cloud/host/HostVO.java
   index 1c3d7c4267..a78b940142 100644
   --- a/engine/schema/src/main/java/com/cloud/host/HostVO.java
   +++ b/engine/schema/src/main/java/com/cloud/host/HostVO.java
   @@ -677,7 +677,7 @@ public class HostVO implements Host {
   
        @Override
        public String toString() {
   -        return new StringBuilder("Host[").append("-").append(id).append("-").append(type).append("]").toString();
   +        return new StringBuilder("Host[").append(name).append("-").append(id).append("-").append(type).append("]").toString();
        }
   
        public void setHypervisorType(HypervisorType hypervisorType) {
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org