You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2022/04/26 18:56:35 UTC

[GitHub] [gobblin] homatthew commented on a diff in pull request #3494: [GOBBLIN-1633] Fix compaction actions on job failure not retried if compaction succeeds

homatthew commented on code in PR #3494:
URL: https://github.com/apache/gobblin/pull/3494#discussion_r859047519


##########
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/verify/CompactionTimeRangeVerifier.java:
##########
@@ -99,7 +99,8 @@ public Result verify(FileSystemDataset dataset) {
         if (compactState.contains(CompactionSlaEventHelper.LAST_RUN_START_TIME)
             && compactState.getPropAsLong(CompactionSlaEventHelper.LAST_RUN_START_TIME)
             > latestEligibleCompactTime.getMillis()) {
-          log.warn("Last compaction for {} is {}, not before {}", dataset.datasetRoot(),
+          log.warn("Last compaction for {} is {}, which is not before latestEligibleCompactTime={}",

Review Comment:
   Readability improvement for log line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org