You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2017/01/09 21:45:15 UTC
[kudu-CR] Fix some minor compilation issues
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5643
Change subject: Fix some minor compilation issues
......................................................................
Fix some minor compilation issues
A few small issues manifested themselves while compiling Impala with
Kudu's RPC and util libraries. Clearly they're not an issue for Kudu
right now but might just be lying dormant.
Change-Id: Ie864271628c77544cfe26fcb469a0e403f06d4a8
---
M src/kudu/util/debug-util.cc
M src/kudu/util/env.h
M src/kudu/util/kernel_stack_watchdog.cc
M src/kudu/util/subprocess.cc
M src/kudu/util/trace_metrics.cc
5 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/5643/1
--
To view, visit http://gerrit.cloudera.org:8080/5643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie864271628c77544cfe26fcb469a0e403f06d4a8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
[kudu-CR] Fix some minor compilation issues
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Fix some minor compilation issues
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie864271628c77544cfe26fcb469a0e403f06d4a8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Fix some minor compilation issues
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Fix some minor compilation issues
......................................................................
Fix some minor compilation issues
A few small issues manifested themselves while compiling Impala with
Kudu's RPC and util libraries. Clearly they're not an issue for Kudu
right now but might just be lying dormant.
Change-Id: Ie864271628c77544cfe26fcb469a0e403f06d4a8
Reviewed-on: http://gerrit.cloudera.org:8080/5643
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/util/debug-util.cc
M src/kudu/util/env.h
M src/kudu/util/kernel_stack_watchdog.cc
M src/kudu/util/subprocess.cc
M src/kudu/util/trace_metrics.cc
5 files changed, 10 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie864271628c77544cfe26fcb469a0e403f06d4a8
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Fix some minor compilation issues
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Fix some minor compilation issues
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie864271628c77544cfe26fcb469a0e403f06d4a8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No