You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@texera.apache.org by GitBox <gi...@apache.org> on 2026/07/23 02:32:18 UTC
[GH] (texera/gh-readonly-queue/main/pr-6763-de7ecba810a7e0190e6fcf122d22f68ded09c15f): Workflow run "Required Checks" is working again!
The GitHub Actions job "Required Checks" on texera.git/gh-readonly-queue/main/pr-6763-de7ecba810a7e0190e6fcf122d22f68ded09c15f has succeeded.
Run started by GitHub user aglinxinyuan (triggered by aglinxinyuan).
Head commit for run:
a2683061355f0783e663e6c515d28e4a5ec53938 / Meng Wang <me...@uci.edu>
test(frontend): cover FiltersComponent master-filter-list building and dropdown reset (#6763)
### What changes were proposed in this PR?
Extends the existing `FiltersComponent` spec to cover the filter-list
helpers it
had left untested
(`frontend/src/app/dashboard/component/user/filters/filters.component.ts`).
> Note: most of the methods the issue lists are already covered —
search-parameter
> assembly (`getSearchKeywords` / `getSearchFilterParameters`),
operator/owner/id
> backend setup (`searchParameterBackendSetup`, asserted via the
logged-out init
> test), the `updateSelected*` handlers, `updateDropdownMenus`, and
> `buildMasterFilterList` date handling. This PR fills the remaining
gaps.
6 tests cover:
- `checkIfWorkflowName` — a plain tag is a name, a known-prefix tag
(`owner: …`) is
a filter, an unrecognized prefix is still a name;
- `updateMasterFilterList` — appends new tags, replaces the `ctime` tag
in place,
and drops tags absent from the new list;
- `setMasterFilterList` — emits on `masterFilterListChange` only when
the list
actually changes;
- `removeInvalidFilterTag` — drops the given tag;
- `setDropdownSelectionsToUnchecked` — clears every dropdown checkbox.
Per the issue's timezone note, `getFormattedDateString` is left to the
existing
TZ-safe date tests (which read the local calendar fields, matching the
component's
local `new Date(y, m, d)`); no new timezone-dependent assertion is
introduced. No
production code was changed.
### Any related issues, documentation, discussions?
Closes #6751
### How was this PR tested?
Extended unit tests, run locally in `frontend/` (all green; the failure
path was
verified by breaking an assertion to confirm the suite goes red):
```
ng test --watch=false --include src/app/dashboard/component/user/filters/filters.component.spec.ts
# Test Files 1 passed (1) | Tests 38 passed (38)
prettier --write <spec> # clean
eslint <spec> # clean
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8 [1M context])
Report URL: https://github.com/apache/texera/actions/runs/29974037299
With regards,
GitHub Actions via GitBox