You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "sdedic (via GitHub)" <gi...@apache.org> on 2023/01/23 13:00:59 UTC
[GitHub] [netbeans] sdedic opened a new pull request, #5350: Temporary fix: Support extra cluster directories.
sdedic opened a new pull request, #5350:
URL: https://github.com/apache/netbeans/pull/5350
This PR patches just the vsnetbeans branch before Apache Language Server for Java extension release; it could be then picked up by `master` and NB17 - or other solution can be applied.
The Apache Language Server supposes that **other extensions** can contribute modules (clusters) into Apache Netbeans language server (part of vscode extension). For example we (Oracle) deliver jdbc drivers that cannot be distributed through Apache (e.g. licensing issues).
The original code uses a misfeature that if a `extra_clusters` env variable is defined, and the application's config file (`conf/nbcode.conf` in this case) **does not** provide a value in its [`conf/app.conf`](https://github.com/apache/netbeans/blob/master/harness/apisupport.harness/release/etc/app.conf#L68) (which is the vscode extension case), the launcher shell script [reads it](https://github.com/apache/netbeans/blob/master/harness/apisupport.harness/release/launchers/app.sh#L56) as a local variable. But if the variable is not defined at all, the [`$extra_clusters` will pick](https://github.com/apache/netbeans/blob/master/harness/apisupport.harness/release/launchers/app.sh#L120) environment variable value, if defined
This approach however does not work on Windows, where the native launcher itself parses `conf/app.conf` into variables and does not do the fallback to the env vars. The bug seems to be present from NBLS inception, at least from 10/2020.
This patch changes the way how extra clusters can be configured and adds support for that through a new System property in the NB core.
**NOTE**: originally I thought this is suitable as a temporary solution, and launchers ought to be updated in the `master` (and NB17 release). But as I am thinking about it, I am somewhat inclined to define this as the official NB core API in `arch.xml` as it would not require changes to the native launcher(s) ... although setting back the system property is not clean at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #5350: Temporary fix: Support extra cluster directories.
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic merged PR #5350:
URL: https://github.com/apache/netbeans/pull/5350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5350: Temporary fix: Support extra cluster directories.
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #5350:
URL: https://github.com/apache/netbeans/pull/5350#issuecomment-1401013449
All green, merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists