[jira] Commented: (HARMONY-3469) [classlib][archive]equalsIgnoreCase in the inner class Name could be optimized

["Alexey Petrenko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HARMONY-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483117 ] 

Alexey Petrenko commented on HARMONY-3469:
------------------------------------------

Tony,

have you made any performance measurements for this patch?

My concern is that we will have two additional object creations (StringBuffer, String) after your patch comparing to String.equalsIgnoreCase usage.

Thanks in advance.

P.S. According ASCII characters in attribute names... It is more important the the spec limits names to the following characters: [0-9a-zA-Z_-] :)

> [classlib][archive]equalsIgnoreCase in the inner class Name could be optimized
> ------------------------------------------------------------------------------
>
>                 Key: HARMONY-3469
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3469
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: Classlib
>            Reporter: Tony Wu
>         Assigned To: Alexey Petrenko
>         Attachments: harmony-3469.diff
>
>
> The code in Name's constructor guarantees that its field "name" is composed  in ASCII haracters.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.