You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/25 04:40:18 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24384: [SPARK-27477][BUILD] Kafka token provider should have provided dependency on Spark

dongjoon-hyun commented on a change in pull request #24384: [SPARK-27477][BUILD] Kafka token provider should have provided dependency on Spark
URL: https://github.com/apache/spark/pull/24384#discussion_r278393975
 
 

 ##########
 File path: external/kafka-0-10-token-provider/pom.xml
 ##########
 @@ -39,6 +39,7 @@
       <groupId>org.apache.spark</groupId>
       <artifactId>spark-core_${scala.binary.version}</artifactId>
       <version>${project.version}</version>
+      <scope>provided</scope>
 
 Review comment:
   cc @gaborgsomogyi 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org